DO NOT MERGE: Smoke-test of a costly “always compute old-style IDs” approach #24419
Conversation
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mtrmac The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
added
the
needs-rebase
openshift-ci
bot
added
the
approved
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
mtrmac
force-pushed
the
mitr-zstd-costly-old-ids-integration
branch
from
c179f32
to
5345c94
Compare
|
Ephemeral COPR build failed. @containers/packit-build please check. |
1 similar comment
|
Ephemeral COPR build failed. @containers/packit-build please check. |
mtrmac
changed the title
…ifferent methods" This reverts commit 1d7ec1e. Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Read the full one, not the truncated one Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
mitr-zstd-costly-old-ids-integration
branch
5 times, most recently
from
3f58ebf
to
3d26edf
Compare
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
Signed-off-by: Miloslav Trmač <mitr@redhat.com>
mtrmac
force-pushed
the
mitr-zstd-costly-old-ids-integration
branch
from
3d26edf
to
85bf387
Compare
|
Note to self: If/after containers/storage#2156 merges, this PR will need to re-enable |
This is a variant of #24287 which reverts (some of) the system test changes to again expect old-style IDs, and includes containers/storage#2155 / containers/image#2613 .
This exists purely to give us options. With this, zstd:chunked loses some of the performance wins, and it should revert to old-style IDs. We then have the option to reintroduce the ID change and performance improvement (perhaps even based on measurements) later.
And, separately, this enforces that layers should match against the config’s DiffIDs, resolving the signing ambiguity.
FYI @giuseppe @edsantiago @mheon @baude
Does this PR introduce a user-facing change?