Disable partial pulls (zstd:chunked) by default #2156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nalind
force-pushed
the
config-disable-partial-pull
branch
from
c370d61
to
e5621a2
Compare
cgwalters
approved these changes
Oct 31, 2024
cgwalters
changed the title
|
/approve |
|
@kwilczynski: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, kwilczynski, nalind The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold |
nalind
force-pushed
the
config-disable-partial-pull
branch
from
e5621a2
to
036685a
Compare
|
/unhold |
nalind
force-pushed
the
config-disable-partial-pull
branch
2 times, most recently
from
128faee
to
b4f7a86
Compare
Disable the storage.options.pull_options.enable_partial_images option by default, so that it will have to be explicitly enabled in order to be used. Update the apply-diff-from-staging-directory integration test to call the test helper binary directly, so that the configuration file the test writes won't have its settings overridden by command line options that the storage() test helper function adds. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
config-disable-partial-pull
branch
from
b4f7a86
to
435aa93
Compare
This was referenced Nov 4, 2024
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable partial pulls by default.
Add a helper command to print the library configuration after parsing everything which may be useful for diagnostic purposes.
Update the
apply-diff-from-staging-directoryintegration test to call the test helper binary directly, so that the configuration file the test writes won't have its settings overridden by command line options that thestorage()test helper function adds.Resolves https://issues.redhat.com/browse/RUN-2335