-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the storage.conf configuration file template #4681
base: master
Are you sure you want to change the base?
Update the storage.conf configuration file template #4681
Conversation
Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
/assign kwilczynski |
@haircommander, please have a look when you have a moment. Thank you! |
/approve |
/retest |
3 similar comments
/retest |
/retest |
/retest |
96ad5f1
to
18a0dc6
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: haircommander, kwilczynski The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
@kwilczynski: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
- What I did
Updated current storage.conf configuration file template to reflect changes made over time to the upstream dependencies such as containers/storage package, etc. The changes include:
size
attribute from thestorage
table into the specific file system driver tablerunroot
property from thestorage
table to reflect changes to the temporary directory default locationstorage.options
tableRemap-User/Group
settings precedence overRemap-UIDs/GIDs
when both are setstorage.options.thinpool
table entirely, as the support for DeviceMapper driver has been removeduse_hard_links
andostree_repos
properties tostorage.options.pull_options
table with their default valuesRelated:
- How to verify it
Run a test OpenShift cluster using ClusterBot that references this Pull Request, or manually apply configuration file changes against a running CRI-O instance and reload the configuration file or restart the service itself.
- Description for the changelog
Update the storage.conf configuration file template to reflect changes made over time to the upstream dependencies.