Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the storage.conf configuration file template #4681

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kwilczynski
Copy link
Member

@kwilczynski kwilczynski commented Nov 5, 2024

- What I did

Updated current storage.conf configuration file template to reflect changes made over time to the upstream dependencies such as containers/storage package, etc. The changes include:

  • Move the size attribute from the storage table into the specific file system driver table
  • Update the runroot property from the storage table to reflect changes to the temporary directory default location
  • Mention the storage.options table Remap-User/Group settings precedence over Remap-UIDs/GIDs when both are set
  • Remove the storage.options.thinpool table entirely, as the support for DeviceMapper driver has been removed
  • Disable the partial container image downloads as it is still considered an experimental feature that should be opt-in
  • Add use_hard_links and ostree_repos properties to storage.options.pull_options table with their default values

Related:

- How to verify it

Run a test OpenShift cluster using ClusterBot that references this Pull Request, or manually apply configuration file changes against a running CRI-O instance and reload the configuration file or restart the service itself.

- Description for the changelog

Update the storage.conf configuration file template to reflect changes made over time to the upstream dependencies.

Signed-off-by: Krzysztof Wilczyński <kwilczynski@redhat.com>
@kwilczynski
Copy link
Member Author

/assign kwilczynski

@kwilczynski
Copy link
Member Author

@giuseppe and @mtrmac, please have a look. Thank you!

@kwilczynski
Copy link
Member Author

@haircommander, please have a look when you have a moment. Thank you!

@haircommander
Copy link
Member

/approve

@kwilczynski
Copy link
Member Author

/retest

3 similar comments
@kwilczynski
Copy link
Member Author

/retest

@kwilczynski
Copy link
Member Author

/retest

@kwilczynski
Copy link
Member Author

/retest

@kwilczynski kwilczynski force-pushed the feature/update-storage.conf-for-cri-o branch from 96ad5f1 to 18a0dc6 Compare November 7, 2024 10:30
Copy link
Contributor

openshift-ci bot commented Nov 7, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: haircommander, kwilczynski
Once this PR has been reviewed and has the lgtm label, please assign cheesesashimi for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kwilczynski
Copy link
Member Author

/retest

4 similar comments
@kwilczynski
Copy link
Member Author

/retest

@kwilczynski
Copy link
Member Author

/retest

@kwilczynski
Copy link
Member Author

/retest

@kwilczynski
Copy link
Member Author

/retest

Copy link
Contributor

openshift-ci bot commented Nov 11, 2024

@kwilczynski: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 18a0dc6 link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@kwilczynski
Copy link
Member Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants