Use fake images for machine tests #27493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: baude The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-ci
bot
added
the
do-not-merge/work-in-progress
baude
force-pushed
the
speedLinux
branch
2 times, most recently
from
5031ea4 to
b8955e2
Compare
In tests that do not start a machine, we can use "fake" images to speed up tests. In the case of darwin and Linux, that can be /dev/null. The hypervisors don't care. In the case of Windows, some research will need to be done to determine the same approach but this is a start. Signed-off-by: Brent Baude <bbaude@redhat.com>
Collaborator
|
LGTM |
Member
|
+1 from me - we are having serious timing issues with these tests. |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Luap99
reviewed
Nov 10, 2025
Member
Luap99
left a comment
Luap99
left a comment
There was a problem hiding this comment.
I don't care to much, I am fine merging as is but I think a a small doc on when/how to use it would help contributors understand when to use it.
If you like to merge as is feel free to drop the hold
/lgtm
/hold
| fakeImagePath string = os.DevNull | ||
| ) | ||
|
|
||
| func (i *initMachine) withFakeImage(_ *machineTestBuilder) *initMachine { |
Member
There was a problem hiding this comment.
minor style nits, given this is the same for everything except windows it would be less duplication to create a new file config_fakeimage.go that uses //go:build !windows as build tag
Also it would be good to add a function comment as documentation what this is for, i.e. when to use this in tests.
openshift-ci
bot
added
the
do-not-merge/hold
Member
Author
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
baude
added a commit
to baude/podman
that referenced
this pull request
Nov 11, 2025
this pr is a follow on to containers#27493. it adds support for hyperv "fake" images and suggests a benefit in terms of test speed. for hyperv, we create a generic 4MB vhdx and stick it into the temp dir. this saves us from any image copy or compression. i also followed up on a few comments Paul made about using windows|unix instead of each platform. Signed-off-by: Brent Baude <bbaude@redhat.com>
baude
added a commit
to baude/podman
that referenced
this pull request
Nov 11, 2025
this pr is a follow on to containers#27493. it adds support for hyperv "fake" images and suggests a benefit in terms of test speed. for hyperv, we create a generic 4MB vhdx and stick it into the temp dir. this saves us from any image copy or compression. i also followed up on a few comments Paul made about using windows|unix instead of each platform. Signed-off-by: Brent Baude <bbaude@redhat.com>
baude
added a commit
to baude/podman
that referenced
this pull request
Nov 11, 2025
this pr is a follow on to containers#27493. it adds support for hyperv "fake" images and suggests a benefit in terms of test speed. for hyperv, we create a generic 4MB vhdx and stick it into the temp dir. this saves us from any image copy or compression. i also followed up on a few comments Paul made about using windows|unix instead of each platform. Signed-off-by: Brent Baude <bbaude@redhat.com>
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Nov 12, 2025
Two PRs[1,2] were merged without rebasing resulting in a conflict since the one enabled gofumpt while the other PR contained formatting not according to that so now the lint fails. [1] containers#27498 [2] containers#27493 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
baude
added a commit
to baude/podman
that referenced
this pull request
Nov 12, 2025
this pr is a follow on to containers#27493. it adds support for hyperv "fake" images and suggests a benefit in terms of test speed. for hyperv, we create a generic 4MB vhdx and stick it into the temp dir. this saves us from any image copy or compression. i also followed up on a few comments Paul made about using windows|unix instead of each platform. Signed-off-by: Brent Baude <bbaude@redhat.com>
baude
added a commit
to baude/podman
that referenced
this pull request
Nov 12, 2025
this pr is a follow on to containers#27493. it adds support for hyperv "fake" images and suggests a benefit in terms of test speed. for hyperv, we create a generic 4MB vhdx and stick it into the temp dir. this saves us from any image copy or compression. i also followed up on a few comments Paul made about using windows|unix instead of each platform. Signed-off-by: Brent Baude <bbaude@redhat.com>
baude
added a commit
to baude/podman
that referenced
this pull request
Nov 12, 2025
this pr is a follow on to containers#27493. it adds support for hyperv "fake" images and suggests a benefit in terms of test speed. for hyperv, we create a generic 4MB vhdx and stick it into the temp dir. this saves us from any image copy or compression. i also followed up on a few comments Paul made about using windows|unix instead of each platform. Signed-off-by: Brent Baude <bbaude@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In tests that do not start a machine, we can use "fake" images to speed up tests. In the case of darwin and Linux, that can be /dev/null. The hypervisors don't care.
In the case of Windows, some research will need to be done to determine the same approach but this is a start.
Checklist
Ensure you have completed the following checklist for your pull request to be reviewed:
commits. (
git commit -s). (If needed, usegit commit -s --amend). The author email must matchthe sign-off email address. See CONTRIBUTING.md
for more information.
Fixes: #00000in commit message (if applicable)make validatepr(format/lint checks)Noneif no user-facing changes)Does this PR introduce a user-facing change?