enable gofumpt formatter #27498
Merged
enable gofumpt formatter #27498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note-none
approved
github-actions
bot
added
machine
kind/api-change
Based on our discussion gofumpt won the vote so use that one via golangci-lint. containers#27291 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Document the formatter we use. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Member
|
@containers/podman-maintainers PTAL. I think we should get this in asap as it will affect most other main branch PRs, if not all. |
Member
|
/lgtm |
Luap99
added a commit
to Luap99/libpod
that referenced
this pull request
Nov 12, 2025
Two PRs[1,2] were merged without rebasing resulting in a conflict since the one enabled gofumpt while the other PR contained formatting not according to that so now the lint fails. [1] containers#27498 [2] containers#27493 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on our discussion gofumpt won the vote so use that one via
golangci-lint.
#27291
Does this PR introduce a user-facing change?