[INTEG-1417] Update aiig create upload function to handle latest upload function for both spaceId and environmentId #5324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ecommerce-app-base-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ryunsong-contentful
added
the
do not merge
…or both spaceId and environmentId
jsdalton
force-pushed
the
INTEG-1417-final
branch
from
9a9fa4d to
e3052ce
Compare
|
Currently blocked during testing by https://github.com/contentful/app-upload-to-delivery/pull/269 |
|
Currently blocked by contentful/node-apps-toolkit#461 |
jsdalton
removed
the
do not merge
jsdalton
reviewed
Dec 19, 2023
| @@ -26,6 +26,8 @@ | |||
| "@types/sinon-chai": "^3.2.9", | |||
| "chai": "^4.3.7", | |||
| "mocha": "^10.2.0", | |||
| "node-addon-api": "^7.0.0", | |||
| "node-gyp": "^10.0.1", | |||
There was a problem hiding this comment.
These two are required by sharp 0.33 for our installation to work locally
| ); | ||
| }); | ||
|
|
||
| describe('when environment id not present in upload response', () => { |
There was a problem hiding this comment.
Keep an explicit test that ensures correct behavior if for some reason the old upload (without environment id) is created.
| @@ -10,11 +11,17 @@ const UPLOAD_DOMAIN: Record<string, URL> = { | |||
| ), | |||
| }; | |||
|
|
|||
| type UploadPropsWithEnvironment = { | |||
| // TODO: use upstream UplpadProps directly once environment id has been added | |||
There was a problem hiding this comment.
whitelisab
approved these changes
Dec 19, 2023
| @@ -10,11 +11,17 @@ const UPLOAD_DOMAIN: Record<string, URL> = { | |||
| ), | |||
| }; | |||
|
|
|||
| type UploadPropsWithEnvironment = { | |||
| // TODO: use upstream UplpadProps directly once environment id has been added | |||
There was a problem hiding this comment.
nit: typo in this comment, UplpadPropsshould be UploadProps 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The create asset upload function has been changed to take both spaceId and the environmentId, therefore we need to adjust accordingly to the new api params.
Approach
Testing steps
Testing results on sandbox:
Correct images:
Using environment scoped upload URLs:
Dependencies and/or References
Will require latest contentful-management.js package version or else merging this PR will break the backend