fix: add environment to upload props #2099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description
UploadProps
Motivation and Context
In #2088 we added support for environment-scoped uploads. When an environment id is provided, the upload created is scoped to that environment. When no environment is created, the upload remains at the space level.
We overlooked one type change, however, which is that the
Upload
object returned from the API will have the environment link in the sys if it has been explicitly environment scoped.Checklist (check all before merging)
When adding a new method:
./lib/export-types.ts