Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add environment to upload props #2099

Merged
merged 2 commits into from
Dec 19, 2023
Merged

Conversation

jsdalton
Copy link
Member

@jsdalton jsdalton commented Dec 19, 2023

Summary

Description

  • Include environment as optional parameter in UploadProps

Motivation and Context

In #2088 we added support for environment-scoped uploads. When an environment id is provided, the upload created is scoped to that environment. When no environment is created, the upload remains at the space level.

We overlooked one type change, however, which is that the Upload object returned from the API will have the environment link in the sys if it has been explicitly environment scoped.

Checklist (check all before merging)

  • Both unit and integration tests are passing
  • There are no breaking changes
  • Changes are reflected in the documentation

When adding a new method:

  • The new method is exported through the default and plain CMA client
  • All new public types are exported from ./lib/export-types.ts
  • Added a unit test for the new method
  • Added an integration test for the new method
  • The new method is added to the documentation

@jsdalton jsdalton marked this pull request as ready for review December 19, 2023 15:47
@jsdalton jsdalton requested a review from a team as a code owner December 19, 2023 15:47
@jsdalton jsdalton changed the title Fix/correct upload type fix: add environment to upload props Dec 19, 2023
@jsdalton jsdalton merged commit 629cb2d into master Dec 19, 2023
2 checks passed
@jsdalton jsdalton deleted the fix/correct-upload-type branch December 19, 2023 15:52
@contentful-automation
Copy link
Contributor

🎉 This PR is included in version 11.7.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants