Skip to content

Conversation

@umeshmore45
Copy link
Contributor

No description provided.

umeshmore45 and others added 2 commits August 18, 2025 18:42
…t script Changed Path change line seq of file from CRLF TO LF
fix: update ENTRYPOINT path and handle permission errors in entrypoin…
@umeshmore45 umeshmore45 requested a review from a team as a code owner August 18, 2025 13:15
@umeshmore45 umeshmore45 requested review from Copilot and sayalijoshi27 and removed request for a team August 18, 2025 13:15
@umeshmore45 umeshmore45 merged commit 910a996 into pre-stage Aug 18, 2025
7 checks passed
@umeshmore45 umeshmore45 deleted the dev branch August 18, 2025 13:15
@umeshmore45 umeshmore45 restored the dev branch August 18, 2025 13:16
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes Docker container startup issues by improving error handling and correcting the entrypoint path. The changes ensure the container can start successfully even when permission operations fail and properly locate the entrypoint script.

Key Changes

  • Added error handling to prevent container failure when permission fixes fail
  • Corrected the Docker entrypoint script path to use the full absolute path

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
upload-api/docker-entrypoint.sh Added `
upload-api/Dockerfile Updated ENTRYPOINT to use absolute path /usr/local/bin/docker-entrypoint.sh

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.


# Fix permissions for extracted_files volume at runtime
chown -R nodeapp:nodeapp /app/extracted_files
chown -R nodeapp:nodeapp /app/extracted_files || true
Copy link

Copilot AI Aug 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using || true to suppress all chown failures may mask legitimate permission issues. Consider checking if the directory exists first or logging the error: chown -R nodeapp:nodeapp /app/extracted_files 2>/dev/null || echo "Warning: Could not change ownership of /app/extracted_files"

Suggested change
chown -R nodeapp:nodeapp /app/extracted_files || true
if [ -d /app/extracted_files ]; then
chown -R nodeapp:nodeapp /app/extracted_files 2>/dev/null || echo "Warning: Could not change ownership of /app/extracted_files" >&2
fi

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants