Skip to content

Conversation

@continue-staging
Copy link

@continue-staging continue-staging bot commented Jan 8, 2026

Summary

Fixes a test name mismatch issue where the test name contradicted its assertion in the isResolveThreadCommand utility function.

Changes

  • Fixed the implementation: Updated the regex pattern to use word boundaries (\b) to properly distinguish between resolveReviewThread and unresolveReviewThread
  • Fixed the test: Updated the test assertion to expect false for unresolveReviewThread, which now matches the test name "should not match unresolveReviewThread"
  • Updated comments: Clarified that the function now correctly excludes unresolveReviewThread due to word boundary matching

Issue Addressed

The original issue was that the test was named "should not match unresolveReviewThread" but was asserting toBe(true), creating confusion about the intended behavior. The implementation was also using simple substring matching which incorrectly matched unresolveReviewThread because it contains resolveReviewThread.

Testing

  • All existing tests continue to pass
  • The specific test now correctly validates that unresolveReviewThread returns false
  • The function still correctly matches resolveReviewThread commands

This task was co-authored by nate and Continue.


Summary by cubic

Fix resolve thread command detection to avoid matching unresolveReviewThread and align the test with its name. This prevents false positives when parsing gh api graphql commands.

  • Bug Fixes
    • Use word boundaries in the regex to match resolveReviewThread only.
    • Update test to expect false for unresolveReviewThread; resolveReviewThread still matches.

Written for commit 199d451. Summary will update on new commits.

- Updated regex to use word boundaries to properly exclude unresolveReviewThread
- Fixed test assertion to match the test name expectation
- Test now correctly expects false for unresolveReviewThread commands

Generated with [Continue](https://continue.dev)

Co-Authored-By: Continue <noreply@continue.dev>
Co-authored-by: nate <nate+staging@continue.dev>
@continue-staging continue-staging bot requested a review from a team as a code owner January 8, 2026 22:17
@continue-staging continue-staging bot requested review from RomneyDa and removed request for a team January 8, 2026 22:17
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jan 8, 2026
@github-actions
Copy link

github-actions bot commented Jan 8, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@continue-staging
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

@continue-staging continue-staging bot merged commit 83e8003 into nate/cn-events Jan 8, 2026
8 of 9 checks passed
@continue-staging continue-staging bot deleted the continue/fix-test-name-mismatch branch January 8, 2026 22:25
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PRs Jan 8, 2026
@github-actions github-actions bot locked and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant