fix: Fix test name mismatch in isResolveThreadCommand #9451
+20
−50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a test name mismatch issue where the test name contradicted its assertion in the
isResolveThreadCommandutility function.Changes
\b) to properly distinguish betweenresolveReviewThreadandunresolveReviewThreadfalseforunresolveReviewThread, which now matches the test name "should not match unresolveReviewThread"unresolveReviewThreaddue to word boundary matchingIssue Addressed
The original issue was that the test was named "should not match unresolveReviewThread" but was asserting
toBe(true), creating confusion about the intended behavior. The implementation was also using simple substring matching which incorrectly matchedunresolveReviewThreadbecause it containsresolveReviewThread.Testing
unresolveReviewThreadreturnsfalseresolveReviewThreadcommandsThis task was co-authored by nate and Continue.
Summary by cubic
Fix resolve thread command detection to avoid matching unresolveReviewThread and align the test with its name. This prevents false positives when parsing gh api graphql commands.
Written for commit 199d451. Summary will update on new commits.