Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 17 additions & 41 deletions extensions/cli/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 2 additions & 4 deletions extensions/cli/src/telemetry/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -227,11 +227,9 @@ describe("isResolveThreadCommand", () => {

it("should not match unresolveReviewThread", () => {
// This tests that we're matching resolveReviewThread specifically
// unresolveReviewThread also contains resolveReviewThread as a substring
// unresolveReviewThread should not match due to word boundary matching
const cmd = "gh api graphql -f query='mutation { unresolveReviewThread }'";
// Note: This will actually match because "unresolveReviewThread" contains "resolveReviewThread"
// If we want to exclude this, we'd need a more specific regex
expect(isResolveThreadCommand(cmd)).toBe(true);
expect(isResolveThreadCommand(cmd)).toBe(false);
});

it("should not match regular gh api calls", () => {
Expand Down
2 changes: 1 addition & 1 deletion extensions/cli/src/telemetry/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export function isCommentReplyCommand(command: string): boolean {
* Pattern: gh api graphql ... resolveReviewThread
*/
export function isResolveThreadCommand(command: string): boolean {
return /gh api graphql.*resolveReviewThread/i.test(command);
return /gh api graphql.*\bresolveReviewThread\b/i.test(command);
}

/**
Expand Down
Loading
Loading