Skip to content

"scope-empty": [2, "always"] is triggering an error when it shouldn't #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gajus opened this issue Aug 15, 2016 · 2 comments · Fixed by #11
Closed

"scope-empty": [2, "always"] is triggering an error when it shouldn't #10

gajus opened this issue Aug 15, 2016 · 2 comments · Fixed by #11
Labels
bug

Comments

@gajus
Copy link

gajus commented Aug 15, 2016

chore: update documentation generation

This commit has no scope. However, I am getting an error:

⧗ input: chore: update documentation generation
✖ scope must be empty [scope-empty]
✖ found 1 problems, 0 warnings
@marionebl marionebl added the bug label Aug 15, 2016
@marionebl
Copy link
Contributor

Thanks for the report! Adding a regression test and fixing the problem right now.

marionebl added a commit that referenced this issue Aug 15, 2016
@marionebl
fix(rules): respect keyword setting for scope-empty
003df10 
*  add related regression tests
*  default to "never" keyword
*  correctly negate rule result and message for "always"

closes #10
@marionebl marionebl mentioned this issue Aug 15, 2016
Merged
marionebl added a commit that referenced this issue Aug 15, 2016
@marionebl
fix(rules): respect keyword setting for scope-empty (#11)
c646a60 
*  add related regression tests
*  default to "never" keyword
*  correctly negate rule result and message for "always"

closes #10
marionebl added a commit that referenced this issue Aug 15, 2016
@marionebl
chore(release): v1.0.1
875a77d 
<a name="1.0.1"></a>
## [1.0.1](v1.0.0...v1.0.1) (2016-08-15)

### Bug Fixes

* **rules:** respect keyword setting for scope-empty (#11) ([c646a60](c646a60)), closes [#10](#10)
@marionebl
Copy link
Contributor

Fix is released https://github.com/marionebl/conventional-changelog-lint/releases/tag/v1.0.1

marionebl added a commit that referenced this issue Jul 7, 2017
@marionebl
fix(rules): respect keyword setting for scope-empty (#11)
f095f49 
*  add related regression tests
*  default to "never" keyword
*  correctly negate rule result and message for "always"

closes #10
marionebl added a commit that referenced this issue Jul 7, 2017
@marionebl
chore(release): v1.0.1 <a name="1.0.1"></a> ## [1.0.1](v1.0.0...v1.0.1)…
9dcb51d 
… (2016-08-15)

### Bug Fixes

* **rules:** respect keyword setting for scope-empty (#11) ([c646a60](c646a60)), closes [#10](#10)
marionebl added a commit that referenced this issue Jul 10, 2017
@marionebl
fix(rules): respect keyword setting for scope-empty (#11)
c7b0b53 
*  add related regression tests
*  default to "never" keyword
*  correctly negate rule result and message for "always"

closes #10
marionebl added a commit that referenced this issue Jul 10, 2017
@marionebl
chore(release): v1.0.1 <a name="1.0.1"></a> ## [1.0.1](v1.0.0...v1.0.1)…
5eeb37f 
… (2016-08-15)

### Bug Fixes

* **rules:** respect keyword setting for scope-empty (#11) ([c646a60](c646a60)), closes [#10](#10)
marionebl added a commit that referenced this issue Jul 10, 2017
@marionebl
fix(rules): respect keyword setting for scope-empty (#11)
b5da3fc 
*  add related regression tests
*  default to "never" keyword
*  correctly negate rule result and message for "always"

closes #10
marionebl added a commit that referenced this issue Jul 10, 2017
@marionebl
chore(release): v1.0.1 <a name="1.0.1"></a> ## [1.0.1](v1.0.0...v1.0.1)…
e93cdd3 
… (2016-08-15)

### Bug Fixes

* **rules:** respect keyword setting for scope-empty (#11) ([c646a60](c646a60)), closes [#10](#10)
marionebl added a commit that referenced this issue Jul 11, 2017
@marionebl
fix(rules): respect keyword setting for scope-empty (#11)
9b49b82 
*  add related regression tests
*  default to "never" keyword
*  correctly negate rule result and message for "always"

closes #10
marionebl added a commit that referenced this issue Jul 11, 2017
@marionebl
chore(release): v1.0.1 <a name="1.0.1"></a> ## [1.0.1](v1.0.0...v1.0.1)…
eeda780 
… (2016-08-15)

### Bug Fixes

* **rules:** respect keyword setting for scope-empty (#11) ([c646a60](c646a60)), closes [#10](#10)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rules): respect keyword setting for scope-empty conventional-changelog/commitlint
2 participants
@gajus @marionebl