Skip to content

fix(rules): respect keyword setting for scope-empty #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2016

Conversation

marionebl
Copy link
Contributor

  • add related regression tests
  • default to "never" keyword
  • correctly negate rule result and message for "always"

closes #10

*  add related regression tests
*  default to "never" keyword
*  correctly negate rule result and message for "always"

closes #10
@marionebl marionebl merged commit c646a60 into master Aug 15, 2016
marionebl added a commit that referenced this pull request Aug 15, 2016
<a name="1.0.1"></a>
## [1.0.1](v1.0.0...v1.0.1) (2016-08-15)

### Bug Fixes

* **rules:** respect keyword setting for scope-empty (#11) ([c646a60](c646a60)), closes [#10](#10)
@marionebl marionebl deleted the fix/allow-empty-scopes branch March 12, 2017 19:00
marionebl added a commit that referenced this pull request Mar 31, 2017
* add integration tests for getConfiguration
* improve test for presence of user config
* override arrays when merging user config by using mergeWith

fixes #11
marionebl added a commit that referenced this pull request Apr 5, 2017
* add integration tests for getConfiguration
* improve test for presence of user config
* override arrays when merging user config by using mergeWith

fixes #11
marionebl added a commit that referenced this pull request Apr 5, 2017
<a name="1.1.9"></a>
## [1.1.9](v1.1.8...v1.1.9) (2017-04-05)

### Bug Fixes

* **rules:** export subject-min-length rule ([29d149e](29d149e))
* override arrays when merging user configuration ([8637292](8637292)), closes [#11](#11)
marionebl added a commit that referenced this pull request Jul 7, 2017
*  add related regression tests
*  default to "never" keyword
*  correctly negate rule result and message for "always"

closes #10
marionebl added a commit that referenced this pull request Jul 7, 2017
… (2016-08-15)

### Bug Fixes

* **rules:** respect keyword setting for scope-empty (#11) ([c646a60](c646a60)), closes [#10](#10)
marionebl added a commit that referenced this pull request Jul 7, 2017
* add integration tests for getConfiguration
* improve test for presence of user config
* override arrays when merging user config by using mergeWith

fixes #11
marionebl added a commit that referenced this pull request Jul 7, 2017
… (2017-04-05)

### Bug Fixes

* **rules:** export subject-min-length rule ([29d149e](29d149e))
* override arrays when merging user configuration ([8637292](8637292)), closes [#11](#11)
marionebl added a commit that referenced this pull request Jul 10, 2017
*  add related regression tests
*  default to "never" keyword
*  correctly negate rule result and message for "always"

closes #10
marionebl added a commit that referenced this pull request Jul 10, 2017
… (2016-08-15)

### Bug Fixes

* **rules:** respect keyword setting for scope-empty (#11) ([c646a60](c646a60)), closes [#10](#10)
marionebl added a commit that referenced this pull request Jul 10, 2017
* add integration tests for getConfiguration
* improve test for presence of user config
* override arrays when merging user config by using mergeWith

fixes #11
marionebl added a commit that referenced this pull request Jul 10, 2017
… (2017-04-05)

### Bug Fixes

* **rules:** export subject-min-length rule ([29d149e](29d149e))
* override arrays when merging user configuration ([8637292](8637292)), closes [#11](#11)
marionebl added a commit that referenced this pull request Jul 10, 2017
*  add related regression tests
*  default to "never" keyword
*  correctly negate rule result and message for "always"

closes #10
marionebl added a commit that referenced this pull request Jul 10, 2017
… (2016-08-15)

### Bug Fixes

* **rules:** respect keyword setting for scope-empty (#11) ([c646a60](c646a60)), closes [#10](#10)
marionebl added a commit that referenced this pull request Jul 10, 2017
* add integration tests for getConfiguration
* improve test for presence of user config
* override arrays when merging user config by using mergeWith

fixes #11
marionebl added a commit that referenced this pull request Jul 10, 2017
… (2017-04-05)

### Bug Fixes

* **rules:** export subject-min-length rule ([29d149e](29d149e))
* override arrays when merging user configuration ([8637292](8637292)), closes [#11](#11)
marionebl added a commit that referenced this pull request Jul 11, 2017
*  add related regression tests
*  default to "never" keyword
*  correctly negate rule result and message for "always"

closes #10
marionebl added a commit that referenced this pull request Jul 11, 2017
… (2016-08-15)

### Bug Fixes

* **rules:** respect keyword setting for scope-empty (#11) ([c646a60](c646a60)), closes [#10](#10)
marionebl added a commit that referenced this pull request Jul 11, 2017
* add integration tests for getConfiguration
* improve test for presence of user config
* override arrays when merging user config by using mergeWith

fixes #11
marionebl added a commit that referenced this pull request Jul 11, 2017
… (2017-04-05)

### Bug Fixes

* **rules:** export subject-min-length rule ([29d149e](29d149e))
* override arrays when merging user configuration ([8637292](8637292)), closes [#11](#11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

"scope-empty": [2, "always"] is triggering an error when it shouldn't
1 participant