Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Frequency entries can be added to patterns that do not "use frequencies" #173

Closed
landonreed opened this issue Jan 3, 2019 · 1 comment · Fixed by #164
Closed

Editor: Frequency entries can be added to patterns that do not "use frequencies" #173

landonreed opened this issue Jan 3, 2019 · 1 comment · Fixed by #164
Labels
bug released

Comments

@landonreed
Copy link
Contributor

I discovered while building tests for JdbcTableWriter that a trip with a frequency entry can be added to a pattern that does not have useFrequency set to true.
@landonreed landonreed added the bug label Jan 3, 2019
landonreed added a commit that referenced this issue Jan 3, 2019
@landonreed
refactor(writer): fix check for useFrequency when updating patterns o…
55f2d87 
…r trips

This refactor includes a check for Pattern#useFrequency when either a pattern is updated or trips
are updated in order to appropriately trigger other behaviors (for example, keeping stop times in
sync with patter stops travel times or disallowing frequency entries for timetable-based patterns).

fixes #173
This was referenced Jan 3, 2019
Merged
Merged
@landonreed
Copy link
Contributor Author

🎉 This issue has been resolved in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update trip#shape_id and frequency stop_times on pattern updates conveyal/gtfs-lib
1 participant
@landonreed