Bug fix release #175
Merged
Bug fix release #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
landonreed
commented
Jan 4, 2019
•
landonreed
commented
- Fixes Editor: pattern stop travel time updates not applied to frequency trip arrival/departure times #165
- Fixes Missing validation check: always increasing stops_times#shape_dist_traveled #163
- Fixes Editor: Frequency entries can be added to patterns that do not "use frequencies" #173
- Fixes Arbitrary 2 hour limit on frequencies#headway_secs #148
- Refs Add shapeId to already existing trips ibi-group/datatools-ui#385 (UI change needed for final fix)
- Makes progress towards Validator: parity with Google transitfeed feedvalidator #167
- Codecov fix for release commits (runs after semantic release)
…r trips This refactor includes a check for Pattern#useFrequency when either a pattern is updated or trips are updated in order to appropriately trigger other behaviors (for example, keeping stop times in sync with patter stops travel times or disallowing frequency entries for timetable-based patterns). fixes #173
Conflicts: src/test/java/com/conveyal/gtfs/GTFSTest.java
Fix bad date NPE
Validate stop names and trip headsigns
Update trip#shape_id and frequency stop_times on pattern updates
…raveled Validate stop_time#shape_dist_traveled
Codecov Report
@@ Coverage Diff @@
## master #175 +/- ##
=========================================
Coverage ? 57.21%
Complexity ? 791
=========================================
Files ? 144
Lines ? 7276
Branches ? 845
=========================================
Hits ? 4163
Misses ? 2773
Partials ? 340
Continue to review full report at Codecov.
|
Increase headway seconds max to 6 hours
this way it will upload a report for the code coverage after all the commits made with maven-semantic-release have completed. Codecov looks at the most recent commit to master to compare the next report to, so this is needed for code coverage comparisons on PRs to master.
Run codecov after semantic-release
evansiroky
approved these changes
Jan 4, 2019
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.