Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Upgrade the numpy version #2315

Closed
TharukaCkasthuri opened this issue Jan 31, 2023 · 6 comments
Closed

[Feature request] Upgrade the numpy version #2315

TharukaCkasthuri opened this issue Jan 31, 2023 · 6 comments
Labels
feature request feature requests for making TTS better. wontfix This will not be worked on but feel free to help.

Comments

@TharukaCkasthuri
Copy link

TharukaCkasthuri commented Jan 31, 2023

🚀 Feature Description

We are frustrated when working with Coqui TTS as it downgrades the Numpy version in my python environment. Coqui TTS only supports Numpy version 1.22.4, which is an old version. We need newer version of Numpy in python 3.10.

@TharukaCkasthuri TharukaCkasthuri added the feature request feature requests for making TTS better. label Jan 31, 2023
@p0p4k
Copy link
Contributor

p0p4k commented Feb 1, 2023

Hi, have you tried manually updating Numpy? What is the latest version that works well with 🐸 TTS?

@TharukaCkasthuri
Copy link
Author

Yeah. Updating manually works. But appreciate if you can change the requirement file . The latest version works with coqui TTS is numpy==1.23.0.

@marsninja
Copy link

Thanks @p0p4k !! We Jaseci contributors appreciates it and admires the work by you folks!

erogol pushed a commit that referenced this issue Feb 13, 2023
* numpy version for py310

requested in #2315

* Update requirements.txt
@stale
Copy link

stale bot commented Mar 4, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. You might also look our discussion channels.

@stale stale bot added the wontfix This will not be worked on but feel free to help. label Mar 4, 2023
@erogol
Copy link
Member

erogol commented Mar 6, 2023

done in dev

@erogol erogol closed this as completed Mar 6, 2023
@mweinelt
Copy link
Contributor

mweinelt commented Mar 17, 2023

Numpy is now indeed relaxed, but the librosa version pinned is incompatible with latest numpy(==1.24.2) version. In fact tts was working against numpy 1.23.5 before and that is still the latest version that works for me after this release.

Importing librosa on that environment leads to the following traceback for me:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "<string>", line 1, in <lambda>
  File "/nix/store/0n4y44dnaxafqs7cg625aldrb152x7bx-python3-3.10.10/lib/python3.10/importlib/__init__.py", line 126, in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
  File "<frozen importlib._bootstrap>", line 1050, in _gcd_import
  File "<frozen importlib._bootstrap>", line 1027, in _find_and_load
  File "<frozen importlib._bootstrap>", line 1006, in _find_and_load_unlocked
  File "<frozen importlib._bootstrap>", line 688, in _load_unlocked
  File "<frozen importlib._bootstrap_external>", line 883, in exec_module
  File "<frozen importlib._bootstrap>", line 241, in _call_with_frames_removed
  File "/nix/store/hqwqi97ayil2bijhxdlnpy4a1ch1cj3h-python3.10-librosa-0.8.1/lib/python3.10/site-packages/librosa/__init__.py", line 211, in <module>
    from . import core
  File "/nix/store/hqwqi97ayil2bijhxdlnpy4a1ch1cj3h-python3.10-librosa-0.8.1/lib/python3.10/site-packages/librosa/core/__init__.py", line 9, in <module>
    from .constantq import *  # pylint: disable=wildcard-import
  File "/nix/store/hqwqi97ayil2bijhxdlnpy4a1ch1cj3h-python3.10-librosa-0.8.1/lib/python3.10/site-packages/librosa/core/constantq.py", line 1059, in <module>
    dtype=np.complex,
  File "/nix/store/0xhlg0vi0y8m5lxsm8khcqqma8rmy2jr-python3.10-numpy-1.24.2/lib/python3.10/site-packages/numpy/__init__.py", line 305, in __getattr__
    raise AttributeError(__former_attrs__[attr])
AttributeError: module 'numpy' has no attribute 'complex'.
`np.complex` was a deprecated alias for the builtin `complex`. To avoid this error in existing code, use `complex` by itself. Doing this will not modify any behavior and is safe. If you specifically wanted the numpy scalar type, use `np.complex128` here.
The aliases was originally deprecated in NumPy 1.20; for more details and guidance see the original release note at:
    https://numpy.org/devdocs/release/1.20.0-notes.html#deprecations. Did you mean: 'complex_'?

https://github.com/librosa/librosa/blame/0.8.0/librosa/core/constantq.py#L1058

The np.complex attribute was dropped in numpy 1.24.0.

The deprecation for the aliases np.object, np.bool, np.float, np.complex, np.str, and np.int is expired (introduces NumPy 1.20). Some of these will now give a FutureWarning in addition to raising an error since they will be mapped to the NumPy scalars in the future.

https://numpy.org/devdocs/release/1.24.0-notes.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request feature requests for making TTS better. wontfix This will not be worked on but feel free to help.
Projects
None yet
Development

No branches or pull requests

5 participants