Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy version for py310 #2316

Merged
merged 2 commits into from
Feb 13, 2023
Merged

numpy version for py310 #2316

merged 2 commits into from
Feb 13, 2023

Conversation

p0p4k
Copy link
Contributor

@p0p4k p0p4k commented Feb 1, 2023

requested in #2315

@erogol
Copy link
Member

erogol commented Feb 6, 2023

Thanks for the PR but we need == instead of >= to make sure that numpy updates do not go unnoticed. Probably we can set == to the latest numpy version and see if it passes all the tests.

@p0p4k
Copy link
Contributor Author

p0p4k commented Feb 7, 2023

So do we need to just set ==numpy and it will get the latest one right?

@erogol erogol merged commit a365a7e into coqui-ai:dev Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0p4k @erogol