Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Model] HiFiGAN #422

Merged
merged 48 commits into from
Apr 12, 2021
Merged

[New Model] HiFiGAN #422

merged 48 commits into from
Apr 12, 2021

Conversation

erogol
Copy link
Member

@erogol erogol commented Apr 8, 2021

This PR introduces the initial implementation of HiFIGAN in 🐸 territory.

  • It is mainly adopted from the official implementation https://github.com/jik876/hifi-gan
  • It also enables us to import officially released models with slight on-the-fly layer restructuring.
  • audio.py is also updated to allow different log scales as it converts amplitude specs to DB. Traditionally we use log10 however some of the other projects (including HifiGAN) use log scaling. This update allows us to train compatible models with the other projects.
  • Different than the original abstractive design of frog: TTS, we adopt HiFiGAN models with self-sufficient generator and discriminator model files to experiment with the pros and cons of this design choice.
  • Optimizers are configurable from config.json file.
  • Scheduler update steps are moved to the end of the epoch loop.

Thx 👑 @rishikksh20 who initiated the work and helped a lot to experiment and find the bugs.

rishikksh20 and others added 30 commits April 8, 2021 11:14
2) Add remove weight norm layer on Generator
2) Rename MPD disc
3) Re-format remove weight norm generator
* Update code and integrate training code
@erogol erogol merged commit d295d5d into dev Apr 12, 2021
@erogol erogol mentioned this pull request Apr 12, 2021
11 tasks
@erogol erogol deleted the hifigan branch April 28, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants