Session abstraction (Pr68 on previous repo) #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: resources/admin/classes/domain/ResourceStep.php resources/import.php resources/index.php resources/templates/header.php
jeffnm
pushed a commit
that referenced
this pull request
Jan 20, 2017
Require required db connection values (like hostname). Fixes #2
This was referenced Jun 13, 2017
jeffnm
pushed a commit
that referenced
this pull request
Apr 4, 2018
PHP message: PHP Fatal error: Uncaught Exception: There was a problem with the database: Expression #5 of SELECT list is not in GROUP BY clause and contains nonaggregated column 'coral_organizations.OHP.parentOrganizationID' which is not functionally dependent on columns in GROUP BY clause; this is incompatible with sql_mode=only_full_group_by in /var/www/coral/organizations/admin/classes/common/DBService.php:39 Stack trace: #0 /var/www/coral/organizations/admin/classes/common/DBService.php(71): DBService->checkForError() #1 /var/www/coral/organizations/admin/classes/domain/Organization.php(550): DBService->processQuery('SELECT O.organi...', 'assoc') #2 /var/www/coral/organizations/ajax_htmldata.php(895): Organization->search(Array, 'TRIM(LEADING 'T...', '') #3 {main} thrown in /var/www/coral/organizations/admin/classes/common/DBService.php on line 39
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@billdueber initial description:
I was having problems with session files not being unlocked when I needed them, resulting in waits of 30s for some of the Ajax calls. One solution (that allows you to stick with the file-based sessions) is to close the session for writing except for when you actually need to write it.
These changes localize the session stuff to a class (CoralSession.php) that takes care of opening sessions and closing them for writing (leaving them read-only) to avoid this.
This is a pretty big structural change, but I thought I'd at least get a ball in the air and start a discussion.