platform creation bug in usage module (was #36 in non merged repo) #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add new fields to the enhanced acquisitions mode: - Price Tax Excluded - Tax Rate - Price Tax Included Price Tax Included and Payment Amount will be automatically prefilled accoring to the Price Tax Excluded and Tax Rate values.
Conflicts: ajax_forms/getCostForm.php ajax_htmldata/getAcquisitionsDetails.php
…tform for every title.
jcuenod
referenced
this pull request
in wc-library/Coral
Aug 27, 2016
|
creating new platforms for every title sounds like a significant problem. is this problem more limited in scope than what it sounds? If not then this might need to be a priority pull request. |
|
I think we can close this request. It looks like the fixes from: ndlibersa/usage#36 have already made their way into the system in this commit aead8a8#diff-fd07e4c6441b7582feb727729b3133e2 |
jeffnm
pushed a commit
that referenced
this pull request
Jan 20, 2017
Require required db connection values (like hostname). Fixes #2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a bug that appeared in a November commit that creates a new Platform for every title.