Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add typescript support #795

Merged
merged 40 commits into from
Oct 5, 2021

Conversation

ChewingGlass
Copy link
Contributor

Taking over #537 since it has conflicts and not much movement.

Let me know what needs to be done to get this through

ts/package.json Outdated Show resolved Hide resolved
ts/package.json Outdated Show resolved Hide resolved
@armaniferrante
Copy link
Member

Can you give me push access to your repo/branch so that we can get this in more quickly?

@ChewingGlass
Copy link
Contributor Author

Can you give me push access to your repo/branch so that we can get this in more quickly?

Done. Sorry, this is a pretty rushed merge as we're doing the beta monday

ChewingGlass and others added 6 commits September 25, 2021 13:37
Co-authored-by: Armani Ferrante <armaniferrante@gmail.com>
Co-authored-by: Armani Ferrante <armaniferrante@gmail.com>
Co-authored-by: Armani Ferrante <armaniferrante@gmail.com>
@armaniferrante
Copy link
Member

armaniferrante commented Sep 25, 2021

Can you give me push access to your repo/branch so that we can get this in more quickly?

Done. Sorry, this is a pretty rushed merge as we're doing the beta monday

Still don't have push access. Edit. Got it. Thank you.

@armaniferrante
Copy link
Member

Note to self: two things to check

  • bare bones anchor init project
  • hypenated-workspace

@armaniferrante armaniferrante merged commit 0a660d2 into coral-xyz:master Oct 5, 2021
@fanatid
Copy link
Contributor

fanatid commented Oct 26, 2021

Why target/types created only on build but not on idl parse? 😞

@armaniferrante armaniferrante deleted the feature/types branch October 26, 2021 16:09
@armaniferrante
Copy link
Member

Why target/types created only on build but not on idl parse? disappointed

Good point. Filed issue here #935.

.into_iter()
.map(|acc| {
let mut acc = acc;
acc.name = acc.name.to_mixed_case();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a problem with this only now when started updating the project on which I work. Why do we change the account name to mixed case? @ChewingGlass

@tungla20
Copy link

Why anchor build does not generate type file in target/types? I accidentally anchor clean

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants