check for deviceId in optional[0].sourceId for adapterjs compatibility

[m59peacemaker]

Fixes #282

[ibc]

I think this is too hacky. It will throw if constraints.video is undefined, and won't work if constraints.video.mandatory are given, or if sourceId appears in the second or third entry within optional.

Also, please split all those conditions in separate lines to make it more readable:

} else if (
	constraints.video &&
	(
		(constraints.video.optional &&
			constraints.video.optional[0] &&
			typeof constraints.video.optional[0].sourceId === 'string') ||
		(constraints.video.mandatory &&
			constraints.video.mandatory[0] &&
			typeof constraints.video.mandatory[0].sourceId === 'string')
	)
) {

[ibc]

@saghul may you please participate here?

[m59peacemaker]

Indeed, quite terrible. I don't know how you feel about adding dependencies. I would normally use a module: ```js path([ 'video', 'optional', 0, 'sourceId' ], constraints) ``` If the goal is to have iosrtc support only `deviceId` but not get ruined by adapter, then `mandatory` should not be passed in or supported, right?

…

On Thu, May 25, 2017 at 1:26 PM, Iñaki Baz Castillo < ***@***.***> wrote: @saghul <https://github.com/saghul> may you please participate here? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#283 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEKrX96XKlrKAq1wa8jpisF4r1ptSaKoks5r9cfigaJpZM4NmmzJ> .

[ibc]

IMHO this should work without adapter.js stuff. It's adapter the one who is supposed to "adapt" stuff.

[hthetiot]

Using getUserMedia constraints.(video|audio).deviceId and getting values from cordova.plugins.iosrtc.getMediaDevices to get the deviceId and using webrtc-adapter v7.2.1+ works for me.

I think this PR can be closed unless I missed something.
cc @saghul

[hthetiot]

Fixed partially by, but need more work to support mandatory and optional https://github.com/cordova-rtc/cordova-plugin-iosrtc/pull/374/files#diff-fca8d66f1ded96a88bd8bec01423cf9bR100

Will rebase PR soon for 5.0.2

[hthetiot]

Closed in favor of #384