Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getUserMedia video constraints improvements #384

Closed

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Sep 13, 2019

TODO

Note: We should add MediaDeviceInfo.getCapabilities support in the future and navigator.mediaDevices.getSupportedConstraints support instead to properly handle facingMode (https://www.w3.org/TR/mediacapture-streams/#dom-inputdeviceinfo-getcapabilities, https://www.w3.org/TR/mediacapture-streams/#media-track-supported-constraints)

@hthetiot hthetiot added enhancement webrtc-adapter webrtc-adapter related webrtc-api webrtc-api related labels Sep 13, 2019
@hthetiot hthetiot added this to the 5.0.x milestone Sep 13, 2019
@hthetiot hthetiot self-assigned this Sep 13, 2019
@hthetiot hthetiot changed the title handle getUserMedia constraints.video.(optional|mandatory)[0].sourceId getUserMedia video constraints improvements Sep 13, 2019
@hthetiot
Copy link
Contributor Author

will be 5.0.3 i think

@hthetiot
Copy link
Contributor Author

navigator.mediaDevices.enumerateDevices().then(function (devices) {
      console.log('getMediaDevices.ok', devices);
      devices.forEach(function (device, idx) {
        console.log('getMediaDevices.devices', JSON.stringify(device.getCapabilities()));
      });
  }, function (err) {
      console.log('getMediaDevices.err', err);
  });
getMediaDevices.devices {"autoGainControl":[true,false],"channelCount":{"max":2,"min":1},"deviceId":"default","echoCancellation":[true,false],"groupId":"c5ae08c64c7a28b5e797b149823253c7904440d0b8143eb6b4fb9094158aa83d","latency":{"max":0.002902,"min":0},"noiseSuppression":[true,false],"sampleRate":{"max":48000,"min":44100},"sampleSize":{"max":16,"min":16}}
VM635:4 getMediaDevices.devices {"autoGainControl":[true,false],"channelCount":{"max":2,"min":1},"deviceId":"1bc2e47588b30d3c265076f4e889607ac94c9d044a460bf794f25d32ed86274d","echoCancellation":[true,false],"groupId":"c5ae08c64c7a28b5e797b149823253c7904440d0b8143eb6b4fb9094158aa83d","latency":{"max":0.002902,"min":0},"noiseSuppression":[true,false],"sampleRate":{"max":48000,"min":44100},"sampleSize":{"max":16,"min":16}}
VM635:4 getMediaDevices.devices {"autoGainControl":[true,false],"channelCount":{"max":2,"min":1},"deviceId":"a7007850cd66676c841b2f3f09627e431db52af1386662175ddf9ec43d144e9a","echoCancellation":[true,false],"groupId":"be3a79d4ecd07b39e68b04321b91f795ebb451e0603bd9b9a149de5e6d248ff7","latency":{"max":0.002902,"min":0},"noiseSuppression":[true,false],"sampleRate":{"max":48000,"min":44100},"sampleSize":{"max":16,"min":16}}
VM635:4 getMediaDevices.devices {"autoGainControl":[true,false],"channelCount":{"max":2,"min":1},"deviceId":"37a4e5739b4469c5d15795fa1d0358b5cf1018fe772a1ac70d5e6624b05ac84f","echoCancellation":[true,false],"groupId":"eb380bc6fbb3f71e1d619a440b3e765e0c531320231d5abcb15a73f491716c09","latency":{"max":0.002902,"min":0},"noiseSuppression":[true,false],"sampleRate":{"max":48000,"min":44100},"sampleSize":{"max":16,"min":16}}
VM635:4 getMediaDevices.devices {"aspectRatio":{"max":1280,"min":0.001388888888888889},"deviceId":"838583a6c8d28c6150d6c396257d4bb3db18fdf05a0d13138ef4b3d5c194abf2","facingMode":[],"frameRate":{"max":30,"min":1},"groupId":"8d7ea33fce9cf9d804b44b163d67d9fd864422bd176e6414a3d3735ef56bb1e8","height":{"max":720,"min":1},"resizeMode":["none","crop-and-scale"],"width":{"max":1280,"min":1}}

@hthetiot
Copy link
Contributor Author

hthetiot commented Oct 5, 2019

Closed in favor or #399

@hthetiot hthetiot closed this Oct 5, 2019
@hthetiot hthetiot deleted the task/onstraints-video-constraints-improvements branch October 22, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement webrtc-adapter webrtc-adapter related webrtc-api webrtc-api related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant