-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getUserMedia video constraints improvements #384
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hthetiot
added
enhancement
webrtc-adapter
webrtc-adapter related
webrtc-api
webrtc-api related
labels
Sep 13, 2019
hthetiot
changed the title
handle getUserMedia constraints.video.(optional|mandatory)[0].sourceId
getUserMedia video constraints improvements
Sep 13, 2019
will be 5.0.3 i think |
This was referenced Sep 13, 2019
|
Closed in favor or #399 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
Be able to use minAspectRatio/maxAspectRatio Be able to use minAspectRatio/maxAspectRatio #287
Adapter JS change frameRate constraints Adapter JS change frameRate constraints #286
webrtc/adapter breaks deviceId constraint webrtc/adapter breaks deviceId constraint #282
Support for facingMode as a video constraint Support for facingMode as a video constraint #315
Note: We should add MediaDeviceInfo.getCapabilities support in the future and navigator.mediaDevices.getSupportedConstraints support instead to properly handle facingMode (https://www.w3.org/TR/mediacapture-streams/#dom-inputdeviceinfo-getcapabilities, https://www.w3.org/TR/mediacapture-streams/#media-track-supported-constraints)