Added Speakerphone funcionality

[CSantosM]

Hi @hthetiot ,

By default, the audio output is always set to Earpiece speaker. It would be interesting be able to choose whether or not to enable the speakerphone.

This enhancement allows us it, to enable the iPhone speakerphone, exporting the enableSpeakerphone() method. Invoking this we will choose speakerphone as audio output.

Take a look.

[hthetiot]

In the past iosrtc had this feature, but it was removed in favor or following cordova plugin:

• https://github.com/saghul/cordova-plugin-audioroute

Original iosrtc implementation entrypoint:

• https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/3.2.2/dist/cordova-plugin-iosrtc.js#L2521

The problem is your solution is only one way speaker on while "cordova-plugin-audioroute" allow to change back to earpiece and detect change when user plug a device.

I do understand your needs and for me cordova-plugin-audioroute is the real solution for now.

The ideal iosrtc solution would be to SHIM setSinkId and add "audiooutput" to enumerateDevices, that would be an acceptable solution.

• https://developer.mozilla.org/en-US/docs/Web/API/HTMLMediaElement/setSinkId
• https://webrtc.github.io/samples/src/content/devices/multi/
• https://webrtc.github.io/samples/src/content/devices/multi/js/main.js

Would you consider improving the PR in that direction?

"The idea is to not expose stuff not purely related to the WebRTC API."
#271 (comment)

[hthetiot]

See comment:

• Added Speakerphone funcionality #379 (comment)

[hthetiot]

please also check this:

• Using AVAudioSession overrideOutput to speaker causes WebRTC to malfunction #289 (comment)

[CSantosM]

Hello @hthetiot ,

I think your proposal is reasonable. However I don't have enough time to address it. Perhaps in the future I can modify it to meet the requirements.

[saghul]

Sorry @CSantosM but that's not how things work. @hthetiot I suggest you don't land this unless it meets your criteria.

Everyone is busy with their projects, but if you contribute, please, see it through. "I have no time, so here is a hack that works for me, deal with it" is not good enough, sorry.

@hthetiot You are the chief, do as you see fit, this is just my 2 cents.

[CSantosM]

Sorry @saghul, I meant that I will try to improve the code in the future.

[hthetiot]

Done here:

• [Beta] update libwebrtc without iosrtc custom patch to ~M54 #385

Implementation:

• https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/task/libwebrtc-update/src/PluginRTCAudioOutputController.swift
• https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/task/libwebrtc-update/js/iosrtc.js#L93
• https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/task/libwebrtc-update/src/iosrtcPlugin.swift#L905

[hthetiot]

@CSantosM I made the changes on 6.0.0 branch but if you want it soon you may make a PR based on the comment above in master for 5.0.4+

[CSantosM]

Thank you @hthetiot, I will take a look.