Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use dispatchAsyncOnType:RTCDispatcherTypeMain instead of dispatchAsyncOnType:RTCDispatcherTypeCaptureSession to fix ios 14.0.1 crash #585

Merged
merged 3 commits into from
Oct 17, 2020
Merged

Use dispatchAsyncOnType:RTCDispatcherTypeMain instead of dispatchAsyncOnType:RTCDispatcherTypeCaptureSession to fix ios 14.0.1 crash #585

merged 3 commits into from
Oct 17, 2020

Conversation

hthetiot
Copy link
Contributor

@hthetiot hthetiot commented Oct 17, 2020 •
edited
Loading

Fix #578

Testing

To test branch

cordova plugin remove cordova-plugin-iosrtc --verbose
cordova plugin add https://github.com/cordova-rtc/cordova-plugin-iosrtc#bugs/RTCDispatcherTypeMainGeneratingDeviceOrientationNotifications --verbose
cordova platform remove ios --no-save
cordova platform add ios --no-save

@hthetiot hthetiot mentioned this pull request Oct 17, 2020
Closed
1 task
@hthetiot hthetiot changed the title Bugs/rtc dispatcher type main generating device orientation notifications Use dispatchAsyncOnType:RTCDispatcherTypeMain instead of dispatchAsyncOnType:RTCDispatcherTypeCaptureSession to fix ios 14.0.1 crash Oct 17, 2020
@hthetiot hthetiot mentioned this pull request Oct 17, 2020
Closed
3 tasks
@hthetiot hthetiot added this to the 6.0.14 milestone Oct 17, 2020
@hthetiot hthetiot self-assigned this Oct 17, 2020
@hthetiot hthetiot merged commit cdfe684 into master Oct 17, 2020
@hthetiot hthetiot deleted the bugs/RTCDispatcherTypeMainGeneratingDeviceOrientationNotifications branch October 17, 2020 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hthetiot hthetiot

Labels
bug libwebrtc
Projects
None yet
Milestone
6.0.14
1 participant
@hthetiot