-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Black screen when a second iOS user connects to a Twilio room #576
Comments
This comment has been minimized.
This comment has been minimized.
thank you @akilude this help. |
@hthetiot we were able to fix the black screen issue using moving self.eventListenerForAddStream(currentPluginMediaStream!) to the getPluginMediaStream method after line 594 cordova-plugin-iosrtc/src/PluginRTCPeerConnection.swift Lines 589 to 594 in 62648fd
I initially said that we were getting a crash on the simulator. Additionally we tried to replace WebRTC library version 0.72 and on that version we don't get a crash but we get a red screen instead of the video. The screen shot below is from the tester that from the #569 (comment) issue The black screen described in this issue happens when a participant in the room turn off their video and turn it back on. |
thx @samgabriel i will apply the fix, alternativly feel free to make PR. |
Hi @hthetiot I saw #578 but the crash is happening on the simulator running iOS 13.3, The #578 discusses a crash on 14.0.1 and mentions that 14 is ok. When my coworkers connects with his iPhone version 14.0 his app is not crashing. He can share his video and it is visible on the desktop but it crashes the simulator and with M72 it shows the red box above. |
This part is unclear, please make PR so i can see your changes or provide diff. |
@hthetiot have you had a chance to check out the PR? |
@samgabriel sorry i missed the PR looking into ASAP, thank you for helping. |
@samgabriel I did merge #579 on master and plan to release ASAP as part of 6.0.14. I'm waiting for #580 (review) that i also d'like to include in 6.0.14, in case this is not merged by Sunday, I will release 6.0.14 with #579 anyway Sunday. Can @akilude @samgabriel test master to confirm this fix your issue.
|
Thank you again @samgabriel for your assistance. |
@hthetiot the Black screen and red screen issue in the screenshot above was actually also due to the version of WebRTC we updated our fork to version M84 and everything started working normally from iOS 14 |
@hthetiot we just tested it from iOS 14 and we can see the video that was previously not displaying |
@hthetiot actually after updating the device with iOS 14 to version 6.0.14 the simulator is crashing again so definitely need the M84 version |
@hthetiot we tried to update the WebRTC to M84 but with this latest version no videos are showing up it is as if nothing is being published or received. any ideas? |
Assuming you tested master. |
6.0.14 should not crash, you may check that you regenerated iOS, but 6.0.14 does not include black video fix, master or future 6.0.15 does. |
What did you test for M84 (task/8.0.0 branch), I updated to M87 this weekend. |
If you can just test master that our target for this issue. |
@hthetiot Tried master, it seems to be fixed, works with addtrack/ontrack as well |
@hthetiot sorry have been busy with other issues we will try master on the Monday and let you know. We tested with 6.0.14. You said you updated to M87 but the last commit on the lib/WebRTC shows updating to M69. Was that what you were referring to? |
The last know Twillio issue should have been fixed on #605 that has landed on master target is 6.0.16 |
Please read first!
Please use Public Google Group (mailing list) for general technical discussions and questions.
extra/renderer-and-libwebrtc-tests.js
file).Note: If the checkboxes above are not checked (which you do after the issue is posted), the issue will be closed, removing this checkbox will result in automatic closed issue.
Versions affected
Description
This was originally mentioned on #569
With iosrtc running whenever a user connects from iosrtc 6.0.13 using twilio. iosrtc shows black screen for the user's video.
Steps to reproduce
Connect to a video room using twilio. Connect a desktop user using Chrome observe the desktop screen video showing correctly.
Connect another user from an ios app running iosrtc. Observe a blackscreen showing instead of the user's video.
Expected results
iosrtc shows the video of the second user.
Actual results
Black screen
Here is the log file that were able to reproduce consistently.
Here are few things to notice from this log on line 27 and line 40 you see this message
2020-09-24 12:58:03.516767-0400 Brainfuse[1222:42625] iosrtcPlugin#MediaStreamTrack_setListener() | ERROR: pluginMediaStreamTrack with id=9190c7d7-1ff3-4ea7-b099-b8072066c57c does not exist
We trace down the problem to the PluginRTCPeerConnection onaddtrack initializing a new PluginMediaStream but the stream tracks are not registered in the iosrtcPlugin.pluginMediaStreamTracks.
We tried to moving the self.eventListenerForAddStream from peerConnection
cordova-plugin-iosrtc/src/PluginRTCPeerConnection.swift
Line 606 in 62648fd
cordova-plugin-iosrtc/src/PluginRTCPeerConnection.swift
Line 595 in 62648fd
Another thing that is odd is that there are multiple tracks coming from the connection when actually the participant is only publishing one video.
Another issue is that
iosrtc:RTCPeerConnection onEvent() | [type:track, data:{"stream":{"id":"default_C16FB2B0-E8A7-4C60-B551-B8550F416E12","audioTracks":{},"videoTracks":{"bc7609f1-7a77-41e3-b692-b383312ab294":{"readyState":"live","id":"bc7609f1-7a77-41e3-b692-b383312ab294","kind":"video","enabled":true,"trackId":"bc7609f1-7a77-41e3-b692-b383312ab294"},"9190c7d7-1ff3-4ea7-b099-b8072066c57c":{"readyState":"live","id":"9190c7d7-1ff3-4ea7-b099-b8072066c57c","kind":"video","enabled":true,"trackId":"9190c7d7-1ff3-4ea7-b099-b8072066c57c"},"fc56e758-1c99-4966-abb8-fc0ec204321b":{"readyState":"live","id":"fc56e758-1c99-4966-abb8-fc0ec204321b","kind":"video","enabled":true,"trackId":"fc56e758-1c99-4966-abb8-fc0ec204321b"}}},"track":{"readyState":"live","id":"9190c7d7-1ff3-4ea7-b099-b8072066c57c","kind":"video","enabled":true,"trackId":"9190c7d7-1ff3-4ea7-b099-b8072066c57c"},"streamId":"default_C16FB2B0-E8A7-4C60-B551-B8550F416E12","type":"track"}] +1ms
as you can see here these track ids are duplicated which i think the reason we are getting blackscreens
The text was updated successfully, but these errors were encountered: