Fix MediaStreamTrack lifecycle, clone and make GetStats logs silent. #605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a Null error with the eventListener
hthetiot
reviewed
Nov 19, 2020
hthetiot
changed the title
hthetiot
approved these changes
Nov 19, 2020
|
I will make some testing before merging @samgabriel thank you for your contribution. |
hthetiot
reviewed
Nov 19, 2020
hthetiot
reviewed
Nov 19, 2020
hthetiot
reviewed
Nov 19, 2020
hthetiot
reviewed
Nov 19, 2020
This was referenced Nov 19, 2020
hthetiot
changed the title
dgreif
reviewed
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pull request fixes issue #592 the local and remote tracks not visible. The issue was Twilio parses the a=ssrc to get the exact trackIds mapped to the msid. this can seen here https://github.com/twilio/twilio-webrtc.js/blob/87f7e61106f58e29364999d8753c773e5602536f/lib/util/sdp.js#L127-L129 .
There was also a problem after releasing the stream in which the stream id was not being removed from the RTCPeerConnection localtracks leading to the next time someone is trying to publish a track it would fail.