providers/vmware: add missing public functions for non-amd64 #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
VmwareProvider must have a corresponding empty function `parse_netplan_config()` in unsupported part as well, just like the amd64 part. Otherwise build would fail when cross-building afterburn for arm64. ``` error[E0599]: no method named `parse_netplan_config` found for reference `&VmwareProvider` in the current scope --> src/providers/vmware/mod.rs:37:14 | 37 | self.parse_netplan_config() | ^^^^^^^^^^^^^^^^^^^^ method not found in `&VmwareProvider` ```
dongsupark
force-pushed
the
vmware-arm64-unsupported
branch
from
e1324bf
to
13f3dd5
Compare
travier
approved these changes
Jan 10, 2024
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 15, 2024
Update afterburn to 5.5.1, and remove the patch 0003 for fixing cross-build issue of arm64, because the upstream fix coreos/afterburn#1022 is already included in 5.5.1.
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 17, 2024
Update afterburn to 5.5.1, and remove the patch 0003 for fixing cross-build issue of arm64, because the upstream fix coreos/afterburn#1022 is already included in 5.5.1.
dongsupark
added a commit
to flatcar/scripts
that referenced
this pull request
Jan 17, 2024
Update afterburn to 5.5.1, and remove the patch 0003 for fixing cross-build issue of arm64, because the upstream fix coreos/afterburn#1022 is already included in 5.5.1.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v5.5.0,
VmwareProvidermust have a corresponding empty functionparse_netplan_config()in unsupported part as well, just like the amd64 part.Otherwise build would fail when cross-building afterburn for arm64.
See also #888, flatcar/scripts#1467.