Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildextend-live: add osmet-pack-with-cosa-coreinst image.yaml key #1764

Conversation

jlebon
Copy link
Member

@jlebon jlebon commented Oct 5, 2020

When that key is on, we use the coreos-installer from cosa instead of
the target system. This is a temporary hack to unblock the f33 rebase in
next.

See #1761 for details.

@openshift-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

When that key is on, we use the coreos-installer from cosa instead of
the target system. This is a temporary hack to unblock the f33 rebase in
next.

See coreos#1761 for details.
@jlebon jlebon force-pushed the pr/use-cosa-coreos-installer-hack branch from a43e5af to ed6b99b Compare October 5, 2020 20:39
@jlebon
Copy link
Member Author

jlebon commented Oct 5, 2020

Verified I can coreos-assembler buildextend-live --fast on the f33 rebase with this!

@jlebon jlebon marked this pull request as ready for review October 5, 2020 20:39
@dustymabe
Copy link
Member

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dustymabe, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 33fa7e0 into coreos:master Oct 5, 2020
@jlebon
Copy link
Member Author

jlebon commented Oct 6, 2020

This is reverted in #1774.

@jlebon jlebon deleted the pr/use-cosa-coreos-installer-hack branch April 22, 2023 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants