osmet-pack: run coreos-installer in target rootfs #1774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2020
jlebon
force-pushed
the
pr/fcos-qemu-osmet
branch
2 times, most recently
from
66c25d9 to
2812d86
Compare
darkmuggle
approved these changes
Oct 6, 2020
Otherwise, we might get linking issues if the target system has newer e.g. glibc. We could use `bwrap` here instead of `chroot`, but meh this is easier and the block device itself is read-only anyway. I was initially trying to get this code to use the qemu image directly, but we have a bunch of issues there with our systemd services getting confused by the metal disk containing identical boot and root partitions (which... we should circle back to eventually). Closes: coreos#1761
…l key" This reverts commit ed6b99b. We don't need this anymore now that osmet packing uses the rootfs of the target system.
jlebon
force-pushed
the
pr/fcos-qemu-osmet
branch
from
2812d86 to
7984439
Compare
|
New changes are detected. LGTM label has been removed. |
|
(This one just needs another restamp.) |
|
/lgtm (again) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: darkmuggle, jlebon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
jlebon
added a commit
to jlebon/fedora-coreos-config
that referenced
this pull request
Oct 8, 2020
This reverts commit 8382692. We don't need this anymore now that coreos-assembler correctly uses the target rootfs directly to run coreos-installer (see coreos/coreos-assembler#1774).
dustymabe
pushed a commit
to coreos/fedora-coreos-config
that referenced
this pull request
Oct 8, 2020
This reverts commit 8382692. We don't need this anymore now that coreos-assembler correctly uses the target rootfs directly to run coreos-installer (see coreos/coreos-assembler#1774).
kelvinfan001
pushed a commit
to kelvinfan001/fedora-coreos-config
that referenced
this pull request
Dec 14, 2020
This reverts commit 8382692. We don't need this anymore now that coreos-assembler correctly uses the target rootfs directly to run coreos-installer (see coreos/coreos-assembler#1774).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we might get linking issues if the target system has newer
e.g. glibc. We could use
bwraphere instead ofchroot, but meh thisis easier and the block device itself is read-only anyway.
I was initially trying to get this code to use the qemu image directly,
but we have a bunch of issues there with our systemd services getting
confused by the metal disk containing identical boot and root
partitions (which... we should circle back to eventually).
Closes: #1761