Revert "Add org.osbuild.dmverity stage patch" #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 180be1b. That patch is in the latest osbuild in Fedora now.
|
This should fix CI on this repo. |
This was referenced Aug 12, 2024
marmijo
previously approved these changes
Aug 12, 2024
|
LGTM! We will need a backport to rhcos-4.17 since I cut the branch before I saw this PR and it failed building. |
|
OK, there's something going on in CI; |
|
Added a commit there which hopefully should fix CI. |
|
Hmm, looks like rpm-ostree is leaking a bunch of |
This started happening in CI:
```
+ mount -o remount,ro /srv/cache
mount: /srv/cache: mount point is busy.
dmesg(1) may have more information after failed mount system call.
[ 321.026584] Kernel panic - not syncing: Attempted to kill init! exitcode=0x00002000
```
Digging into it, it seems to be due to leftover rofiles-fuse mounts:
```
+ ps aux
...
root 306 0.0 0.1 401092 3972 ? Ssl 15:46 0:00 rofiles-fuse --copyup usr /tmp/rpmostree-rofiles-fuse0QroLi
root 311 0.0 0.1 251564 2488 ? Ssl 15:46 0:00 rofiles-fuse --copyup etc /tmp/rpmostree-rofiles-fuseANAAgx
root 330 0.0 0.2 474828 4120 ? Ssl 15:46 0:00 rofiles-fuse --copyup usr /tmp/rpmostree-rofiles-fuseioSZ7r
root 334 0.0 0.1 251564 2712 ? Ssl 15:46 0:00 rofiles-fuse --copyup etc /tmp/rpmostree-rofiles-fusePPGBR9
...
```
For some reason, rpm-ostree is not able to unmount those.
We should dig into this but as a brutal workaround, just kill them
manually. There's no data loss concerns here; the commit has already
been written and shipped out via virtiofs.
The issue remains tracked at
coreos#3848.
jlebon
force-pushed
the
pr/unpatch-osbuild
branch
from
b1effbf
to
de27dc9
Compare
|
OK, added a brutal workaround for this for now to unblock CI. |
gursewak1997
approved these changes
Aug 13, 2024
|
/cherrypick rhcos-4.17 |
|
@mike-nguyen: new pull request created: #3849 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 180be1b.
That patch is in the latest osbuild in Fedora now.