mantle/platform/aliyun: modify the API to use HTTPS by default #3845
Conversation
|
CI should be fixed by #3844, I'll rebase this PR when it merges. |
marmijo
force-pushed
the
aliyun-use-https
branch
from
37d87ea
to
06063b2
Compare
Attempting to override the http scheme for each request is not working for every request type. Let's set the client config scheme to HTTPS by default. Move away from `NewClientWithAccessKey` and instead create an access key separately and then use `NewClientWithOptions` to create the client with a custom config using "HTTPS" for the scheme. Also remove the scheme override for each request.
marmijo
force-pushed
the
aliyun-use-https
branch
from
06063b2
to
7828651
Compare
|
We'll need to backport this all the way to rhcos-4.12 right? |
Ah, yes we will need to do that. I can go ahead and open those PRs. |
|
I think you can comment |
|
/cherrypick rhcos-4.17 |
|
@marmijo: only coreos org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
I am part of the coreos org though, bot! 😆 Didn't realize I was private. /cherrypick rhcos-4.17 |
|
@marmijo: new pull request created: #3852 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick rhcos-4.16 |
|
@marmijo: new pull request created: #3853 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick rhcos-4.15 |
|
@marmijo: new pull request created: #3854 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick rhcos-4.14 |
|
@marmijo: new pull request created: #3855 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick rhcos-4.13 |
|
@marmijo: new pull request created: #3856 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherrypick rhcos-4.12 |
|
@marmijo: new pull request created: #3857 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Attempting to override the http scheme for each request is not working for every request type. Let's set the client config scheme to HTTPS by default. Move away from
NewClientWithAccessKeyand instead create an access key separately and then useNewClientWithOptionsto create the client with a custom config using "HTTPS" for the scheme.Also remove the scheme override for each request.
This code was tested and is working properly in the new ITUP cluster for the RHCOS pipeline.