[rhcos-4.14] mantle/platform/aliyun: modify the API to use HTTPS by default #3855
Conversation
Attempting to override the http scheme for each request is not working for every request type. Let's set the client config scheme to HTTPS by default. Move away from `NewClientWithAccessKey` and instead create an access key separately and then use `NewClientWithOptions` to create the client with a custom config using "HTTPS" for the scheme. Also remove the scheme override for each request.
|
Hi @openshift-cherrypick-robot. Thanks for your PR. I'm waiting for a coreos member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
This reverts commit 0b659af. That was meant to be a temporary measure but lingered for a while. As mentioned there, ideally, we'd build both, but if we only build one, let it be RHCOS.
|
I think I'll need to backport #3822 to |
|
CoreOS CI shouldn't run on rhcos-* branches. We need to backport 570ef0b. |
It doesn't work properly against these rhcos- branches anyway. Let's just limit the testing to building the container and running check and unittest tests. (cherry picked from commit 511a61d)
This is an automated cherry-pick of #3845
/assign marmijo