Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

15fcos: print warning If Ignition is run more than once #1148

Merged
merged 1 commit into from
Aug 6, 2021
Merged

15fcos: print warning If Ignition is run more than once #1148

merged 1 commit into from
Aug 6, 2021

Conversation

sohankunkerkar
Copy link
Member

This change adds a warning on the serial console if Ignition is run more than once. This is related to coreos/ignition#1214

This needs #1128 and coreos/ignition#1254

@sohankunkerkar sohankunkerkar changed the title [WIP] 15fcos: print warning If Igniton is run more than once 15fcos: print warning If Igniton is run more than once Aug 3, 2021
@bgilbert bgilbert changed the title 15fcos: print warning If Igniton is run more than once 15fcos: print warning If Ignition is run more than once Aug 4, 2021
@bgilbert
Copy link
Contributor

bgilbert commented Aug 6, 2021

#1128 landed.

@sohankunkerkar sohankunkerkar marked this pull request as ready for review August 6, 2021 17:33
@sohankunkerkar
Copy link
Member Author

Fixes coreos/ignition#1214

@sohankunkerkar sohankunkerkar requested a review from jlebon August 6, 2021 19:17
jlebon
jlebon previously approved these changes Aug 6, 2021
Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will let @bgilbert have a look as well.

bgilbert
bgilbert previously approved these changes Aug 6, 2021
overlay.d/15fcos/usr/libexec/coreos-check-ignition-config Outdated Show resolved Hide resolved
This change adds a warning on the serial console if Ignition
is run more than once. This is related to coreos/ignition#1214
@sohankunkerkar sohankunkerkar dismissed stale reviews from bgilbert and jlebon via b3d2be2 August 6, 2021 21:10
@sohankunkerkar sohankunkerkar enabled auto-merge (rebase) August 6, 2021 21:11
@sohankunkerkar sohankunkerkar merged commit d429795 into coreos:testing-devel Aug 6, 2021
@sohankunkerkar sohankunkerkar deleted the ignition-run-more branch August 6, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants