-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
15fcos: print warning If Ignition is run more than once #1148
Merged
sohankunkerkar
merged 1 commit into
coreos:testing-devel
from
sohankunkerkar:ignition-run-more
Aug 6, 2021
Merged
15fcos: print warning If Ignition is run more than once #1148
sohankunkerkar
merged 1 commit into
coreos:testing-devel
from
sohankunkerkar:ignition-run-more
Aug 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgilbert
reviewed
Aug 2, 2021
bgilbert
reviewed
Aug 3, 2021
sohankunkerkar
changed the title
[WIP] 15fcos: print warning If Igniton is run more than once
15fcos: print warning If Igniton is run more than once
Aug 3, 2021
bgilbert
changed the title
15fcos: print warning If Igniton is run more than once
15fcos: print warning If Ignition is run more than once
Aug 4, 2021
bgilbert
reviewed
Aug 5, 2021
#1128 landed. |
Fixes coreos/ignition#1214 |
jlebon
reviewed
Aug 6, 2021
jlebon
reviewed
Aug 6, 2021
jlebon
previously approved these changes
Aug 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will let @bgilbert have a look as well.
bgilbert
previously approved these changes
Aug 6, 2021
This change adds a warning on the serial console if Ignition is run more than once. This is related to coreos/ignition#1214
bgilbert
approved these changes
Aug 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a warning on the serial console if Ignition is run more than once. This is related to coreos/ignition#1214
This needs #1128 and coreos/ignition#1254