stages/files: add previousReport to the result report if Ignition is run more than once #1254
Conversation
sohankunkerkar
force-pushed
the
ignition-prevReport
branch
from
3eebf54 to
d71f4f8
Compare
sohankunkerkar
force-pushed
the
ignition-prevReport
branch
2 times, most recently
from
61fdbab to
4a8e210
Compare
| return fmt.Errorf("reading previous report: %w", err) | ||
| } | ||
| if err == nil { | ||
| err = json.Unmarshal(prevData, &prevReport) |
There was a problem hiding this comment.
Actually, let's log a warning in this case too, similar to the one in coreos/fedora-coreos-config#1148.
There was a problem hiding this comment.
Shouldn't we do this only if we're not on a live system? Otherwise, this will be forever stacking previousReports on each live boot.
There was a problem hiding this comment.
Shouldn't we do this only if we're not on a live system? Otherwise, this will be forever stacking
previousReports on each live boot.
Yeah, that's a good point!
There was a problem hiding this comment.
Each of the stacked Ignition runs affect the live system, so my thinking was that recording the run history was useful. But I'm okay dropping it if we want.
There was a problem hiding this comment.
I'm OK adding onto it I guess, though continually nesting when you know it could keep going forever by design feels weird. Would be more natural if it were a list instead, i.e. previousReports[].
sohankunkerkar
force-pushed
the
ignition-prevReport
branch
from
4a8e210 to
502c201
Compare
sohankunkerkar
changed the title
sohankunkerkar
force-pushed
the
ignition-prevReport
branch
2 times, most recently
from
2ea3db2 to
23e44da
Compare
sohankunkerkar
force-pushed
the
ignition-prevReport
branch
from
23e44da to
37d88d6
Compare
This change notices if a report already exists and accordingly nest the report in previousReport. related to coreos#1214
sohankunkerkar
force-pushed
the
ignition-prevReport
branch
from
37d88d6 to
cbe5c3c
Compare
This change notices if a report already exists and accordingly nest the report in
previousReport.related to #1214
Based on this change, the
fedora-coreos-configcode would check ifpreviousReportexists and could throw a fat warning sayingIgnition was previously run at xx. Unexpected behavior may occur. Ignition is not designed to run more than once per system.