[rhcos-4.16] overlays: drop coreos-multipath-trigger.service
#3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This service was needed in the past to make multipath + LUKS work well. The underlying bug seems to have been fixed now as I can no longer reproduce it in Fedora or RHEL 9.4. Conveniently, this also works around a bug in which that service would sometimes hang because of a bug[[1]] in systemd which is still outstanding in RHEL 9. Drop it. We don't have any tests for this yet. Multipath + LUKS currently doesn't work but should be fixed soon[[2]]. A test will be added as part of that work. [1]: systemd/systemd#29863 [2]: coreos/fedora-coreos-tracker#1728 Fixes: https://issues.redhat.com/browse/OCPBUGS-29325 (cherry picked from commit cc2e865)
The tests won't pass because they run with latest COSA and not the branch specific COSA. Let's just disable them for now. (cherry picked from commit 5be9e14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
overlays: drop
coreos-multipath-trigger.serviceThis service was needed in the past to make multipath + LUKS work well.
The underlying bug seems to have been fixed now as I can no longer
reproduce it in Fedora or RHEL 9.4. Conveniently, this also works around
a bug in which that service would sometimes hang because of a bug[1]
in systemd which is still outstanding in RHEL 9.
Drop it.
We don't have any tests for this yet. Multipath + LUKS currently doesn't
work but should be fixed soon[2]. A test will be added as part of
that work.
Fixes: https://issues.redhat.com/browse/OCPBUGS-29325
(cherry picked from commit cc2e865)