-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.16] OCPBUGS-35748: Bump fedora-coreos-config #1528
[release-4.16] OCPBUGS-35748: Bump fedora-coreos-config #1528
Conversation
@coreosbot-releng: This pull request references Jira Issue OCPBUGS-35748, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
OK weird, that diff looks larger than I'd expect. I think what happened here is that we branched off for 4.16 earlier than when we branched the |
Dusty Mabe (1): .cci.jenkinsfile: disable testing on older RHCOS branch Jonathan Lebon (1): overlays: drop `coreos-multipath-trigger.service`
76f3f20
to
1606fd3
Compare
@coreosbot-releng: This pull request references Jira Issue OCPBUGS-35748, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
OK, this looks better now! Will let /assign @travier @mike-nguyen also review and add the required labels. |
We need to delete the SCOS tests on this branch. But for now /override ci/prow/scos-9-build-test-qemu |
@jlebon: Overrode contexts on behalf of jlebon: ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label backport-risk-assessed |
Skipping C9S tests is openshift/release#53014 |
/lgtm |
/label staff-eng-approved |
@travier: Can not set label staff-eng-approved: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers] In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: c4rt0, coreosbot-releng, mike-nguyen, travier The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@coreosbot-releng: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Talked with @sdodson. He'll look at this on Monday once there's clarity on 4.16 timeline just in case we need to respin RHCOS before GA. |
/label staff-eng-approved |
4729d1f
into
openshift:release-4.16
@coreosbot-releng: Jira Issue OCPBUGS-35748: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-35748 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Created by GitHub workflow (source).