Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.16] OCPBUGS-35748: Bump fedora-coreos-config #1528

Conversation

coreosbot-releng
Copy link

@coreosbot-releng coreosbot-releng commented Jun 18, 2024

Created by GitHub workflow (source).

Dusty Mabe (1):
      .cci.jenkinsfile: disable testing on older RHCOS branch

Jonathan Lebon (1):
      overlays: drop `coreos-multipath-trigger.service`

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 18, 2024
@openshift-ci-robot
Copy link

@coreosbot-releng: This pull request references Jira Issue OCPBUGS-35748, which is invalid:

  • release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
  • expected dependent Jira Issue OCPBUGS-29325 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Created by GitHub workflow (source).

Colin Walters (1):
     buildroot: Add container=oci

Dusty Mabe (1):
     .cci.jenkinsfile: disable testing on older RHCOS branch

Jonathan Lebon (5):
     manifests: dnf5 is now default in rawhide; stop symlinking dnf
     buildroot: update URL to rpm-ostree spec
     tests/kdump: bump timeout for kdump.service
     Revert "tests/kola: use toolbox container image for selinux.podman-tmpfs-context"
     overlays: drop `coreos-multipath-trigger.service`

Michael Armijo (1):
     denylist: extend snooze for `coreos.ignition.ssh.key`

Timothée Ravier (1):
     tests: Update container images to Fedora 40

jbtrystram (1):
     overlay/coreos-check-ssh-keys: Remove invalid service key

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@c4rt0
Copy link
Contributor

c4rt0 commented Jun 19, 2024

/retest

Copy link
Contributor

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2024
@jlebon
Copy link
Member

jlebon commented Jun 19, 2024

OK weird, that diff looks larger than I'd expect.

I think what happened here is that we branched off for 4.16 earlier than when we branched the rhcos-4.16 branch in f-c-c. Anyway, most of those commits are benign/don't affect RHCOS, but to be safe, I'll re-align the f-c-c rhcos-4.16 branch so it's exactly at where the git submodule here is, and only coreos/fedora-coreos-config#3027 added.

Dusty Mabe (1):
      .cci.jenkinsfile: disable testing on older RHCOS branch

Jonathan Lebon (1):
      overlays: drop `coreos-multipath-trigger.service`
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 19, 2024
@openshift-ci-robot
Copy link

@coreosbot-releng: This pull request references Jira Issue OCPBUGS-35748, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-29325 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-29325 targets the "4.17.0" version, which is one of the valid target versions: 4.17.0
  • bug has dependents

Requesting review from QA contact:
/cc @mike-nguyen

In response to this:

Created by GitHub workflow (source).

Dusty Mabe (1):
     .cci.jenkinsfile: disable testing on older RHCOS branch

Jonathan Lebon (1):
     overlays: drop `coreos-multipath-trigger.service`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from mike-nguyen June 19, 2024 18:52
@jlebon
Copy link
Member

jlebon commented Jun 19, 2024

OK, this looks better now!

Will let

/assign @travier @mike-nguyen

also review and add the required labels.

@jlebon
Copy link
Member

jlebon commented Jun 20, 2024

We need to delete the SCOS tests on this branch. But for now

/override ci/prow/scos-9-build-test-qemu
/override ci/prow/scos-9-build-test-metal

Copy link
Contributor

openshift-ci bot commented Jun 20, 2024

@jlebon: Overrode contexts on behalf of jlebon: ci/prow/scos-9-build-test-metal, ci/prow/scos-9-build-test-qemu

In response to this:

We need to delete the SCOS tests on this branch. But for now

/override ci/prow/scos-9-build-test-qemu
/override ci/prow/scos-9-build-test-metal

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mike-nguyen
Copy link
Member

/label backport-risk-assessed
/label cherry-pick-approved
/lgtm

@openshift-ci openshift-ci bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. labels Jun 20, 2024
@travier
Copy link
Member

travier commented Jun 21, 2024

Skipping C9S tests is openshift/release#53014

@travier
Copy link
Member

travier commented Jun 21, 2024

/lgtm

@travier
Copy link
Member

travier commented Jun 21, 2024

/label staff-eng-approved
I don't think I can set that one (yet)

Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

@travier: Can not set label staff-eng-approved: Must be member in one of these teams: [openshift-patch-managers openshift-staff-engineers]

In response to this:

/label staff-eng-approved
I don't think I can set that one (yet)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0, coreosbot-releng, mike-nguyen, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [c4rt0,mike-nguyen,travier]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

@coreosbot-releng: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jlebon
Copy link
Member

jlebon commented Jun 21, 2024

Talked with @sdodson. He'll look at this on Monday once there's clarity on 4.16 timeline just in case we need to respin RHCOS before GA.

@sdodson
Copy link
Member

sdodson commented Jun 24, 2024

/label staff-eng-approved

@openshift-ci openshift-ci bot added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jun 24, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4729d1f into openshift:release-4.16 Jun 24, 2024
7 checks passed
@openshift-ci-robot
Copy link

@coreosbot-releng: Jira Issue OCPBUGS-35748: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35748 has been moved to the MODIFIED state.

In response to this:

Created by GitHub workflow (source).

Dusty Mabe (1):
     .cci.jenkinsfile: disable testing on older RHCOS branch

Jonathan Lebon (1):
     overlays: drop `coreos-multipath-trigger.service`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants