Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci-operator/openshift/os: Remove C9S jobs from 4.16 #53014

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

travier
Copy link
Member

@travier travier commented Jun 10, 2024

Those test jobs only make sense on the main development branch.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 11, 2024
@LorbusChris
Copy link
Member

OKD has two release streams: stable (== 4.16) and next (== 4.17). So I think these tests should still be run somewhere for 4.16

@travier
Copy link
Member Author

travier commented Jun 21, 2024

OKD has two release streams: stable (== 4.16) and next (== 4.17). So I think these tests should still be run somewhere for 4.16

SCOS should be built only once from the master branch and then specialized for OKD versions. It does not make sense to build SCOS based on older OCP.

/pj-rehearse skip

@openshift-ci-robot
Copy link
Contributor

@travier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 21, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 21, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@travier: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-os-release-4.16-images openshift/os presubmit Presubmit changed
pull-ci-openshift-os-release-4.16-rhcos-9-build-test-metal openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.16-rhcos-9-build-test-qemu openshift/os presubmit Ci-operator config changed
pull-ci-openshift-os-release-4.16-validate openshift/os presubmit Ci-operator config changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci-robot openshift-ci-robot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 21, 2024
@travier
Copy link
Member Author

travier commented Jun 21, 2024

/pj-rehearse skip

@openshift-ci-robot
Copy link
Contributor

@travier: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jun 21, 2024
Copy link
Contributor

@HuijingHei HuijingHei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 21, 2024
Copy link
Contributor

@c4rt0 c4rt0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -1,7 +1,7 @@
presubmits:
openshift/os:
- agent: kubernetes
always_run: false
always_run: true

This comment was marked as resolved.

This comment was marked as resolved.

Copy link
Member Author

@travier travier Jun 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part is automatically generated from make update so I never looked at it :)

Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: c4rt0, HuijingHei, travier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Jun 21, 2024

@travier: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ba38c0c into openshift:master Jun 21, 2024
17 checks passed
@travier travier deleted the rm-c9s-openshift-os branch June 21, 2024 11:15
@jlebon
Copy link
Member

jlebon commented Jun 21, 2024

OKD has two release streams: stable (== 4.16) and next (== 4.17). So I think these tests should still be run somewhere for 4.16

SCOS should be built only once from the master branch and then specialized for OKD versions. It does not make sense to build SCOS based on older OCP.

I think the new c9s variant added in openshift/os#1445 will make this really clear because you would then take this OCP/OKD-agnostic bootable container image and derive from it multiple times (once per supported OKD version). Those base composes don't consume the c9s-sig-cloud-okd repo.

JianLi-RH pushed a commit to JianLi-RH/release that referenced this pull request Jul 2, 2024
jtaleric pushed a commit to jtaleric/release that referenced this pull request Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants