-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[next-devel] rebase to Fedora 33 #640
Conversation
Right now
|
697ffea
to
0676ea5
Compare
current important changes when building locally right after building f32:
We can discuss each one of these in the file diff as well. |
0676ea5
to
ad37d90
Compare
This is fixed now with https://bodhi.fedoraproject.org/updates/FEDORA-2020-2fbcdf6262 |
@@ -1,1145 +1,1220 @@ | |||
{ | |||
"packages": { | |||
"ModemManager-glib": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed by fwupd
$ rpm -e ModemManager-glib
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
libmm-glib.so.0()(64bit) is needed by (installed) fwupd-1.4.6-1.fc33.x86_64
}, | ||
"dbus-libs": { | ||
"evra": "1:1.12.20-1.fc32.x86_64" | ||
}, | ||
"dbxtool": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in Fedora 32 this was needed by shim:
[core@localhost ~]$ rpm -e dbxtool
error: Failed dependencies:
dbxtool >= 0.6-3 is needed by (installed) shim-x64-15-8.x86_64
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in Fedora 33 dbxtool
is provided by the fwupd
rpm and not the dbxtool
rpm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not clear to me that shim
should hard require fwupd
.
Now...shipping an OS without a way to update the DBX is probably not a good idea, but fwupd
is now doing a lot.
}, | ||
"diffutils": { | ||
"evra": "3.7-4.fc32.x86_64" | ||
}, | ||
"dmidecode": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed by flashrom
which is needed by fwupd
:
```$ rpm -e dmidecode
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
dmidecode is needed by (installed) flashrom-1.2-3.fc33.x86_64
"evra": "32-3.noarch" | ||
"evra": "33-0.15.noarch" | ||
}, | ||
"fedora-release-identity-coreos": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new package not sure how it automagically gets installed but it looks like we do want it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's coming from fedora-release-common
requiring fedora-release-identity
which fedora-release-identity-coreos
provides. But yeah, seems harmless.
"evra": "32-6.noarch" | ||
"evra": "33-0.13.noarch" | ||
}, | ||
"fedora-repos-modular": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new package. fedora-repos-modular
was broken into a subpackage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: we should sanity-check our disablement still works there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah. it does I think. Part of the reason I knew I needed to add them back is because the "disablement" code was failing :)
"pciutils": { | ||
"evra": "3.6.4-2.fc33.x86_64" | ||
}, | ||
"pciutils-libs": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed by pciutils
(leads to iptables
) and flashrom
(leads to fwupd
):
[core@cosa-devsh ~]$ rpm -e pciutils-libs
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
libpci.so.3()(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
libpci.so.3()(64bit) is needed by (installed) flashrom-1.2-3.fc33.x86_64
libpci.so.3(LIBPCI_3.0)(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
libpci.so.3(LIBPCI_3.0)(64bit) is needed by (installed) flashrom-1.2-3.fc33.x86_64
libpci.so.3(LIBPCI_3.1)(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
libpci.so.3(LIBPCI_3.3)(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
libpci.so.3(LIBPCI_3.3)(64bit) is needed by (installed) flashrom-1.2-3.fc33.x86_64
libpci.so.3(LIBPCI_3.5)(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
libpci.so.3(LIBPCI_3.5)(64bit) is needed by (installed) flashrom-1.2-3.fc33.x86_64
libpci.so.3(LIBPCI_3.6)(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
libpci.so.3(LIBPCI_3.7)(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
pciutils-libs = 3.6.4-2.fc33 is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
manifest-lock.x86_64.json
Outdated
"evra": "2:2.1.0-2.fc32.x86_64" | ||
"evra": "2:2.1.0-0.179.dev.git43f2771.fc33.x86_64" | ||
}, | ||
"podman-plugins": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be dropped soon when new build of podman hits stable that only recommends and doesn't require podman-plugins
.
"evra": "4.0.2-5.fc32.x86_64" | ||
"evra": "4.0.2-6.fc33.x86_64" | ||
}, | ||
"rdma-core": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ultimately needed by iptables
:
[core@cosa-devsh ~]$ rpm -e rdma-core
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
rdma-core(x86-64) = 31.0-1.fc33 is needed by (installed) libibverbs-31.0-1.fc33.x86_64
[core@cosa-devsh ~]$ rpm -e libibverbs
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
libibverbs.so.1()(64bit) is needed by (installed) libpcap-14:1.9.1-5.fc33.x86_64
libibverbs.so.1(IBVERBS_1.0)(64bit) is needed by (installed) libpcap-14:1.9.1-5.fc33.x86_64
libibverbs.so.1(IBVERBS_1.1)(64bit) is needed by (installed) libpcap-14:1.9.1-5.fc33.x86_64
[core@cosa-devsh ~]$ rpm -e libpcap
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
libpcap.so.1()(64bit) is needed by (installed) iptables-libs-1.8.5-3.fc33.x86_64
libpcap.so.1()(64bit) is needed by (installed) nmap-ncat-2:7.80-5.fc33.x86_64
[core@cosa-devsh ~]$ rpm -e iptables-libs
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
iptables-libs(x86-64) = 1.8.5-3.fc33 is needed by (installed) iptables-1.8.5-3.fc33.x86_64
iptables-libs(x86-64) = 1.8.5-3.fc33 is needed by (installed) iptables-nft-1.8.5-3.fc33.x86_64
libip4tc.so.2()(64bit) is needed by (installed) systemd-246.6-3.fc33.x86_64
libip4tc.so.2()(64bit) is needed by (installed) iptables-1.8.5-3.fc33.x86_64
libip6tc.so.2()(64bit) is needed by (installed) iptables-1.8.5-3.fc33.x86_64
libxtables.so.12()(64bit) is needed by (installed) iptables-1.8.5-3.fc33.x86_64
libxtables.so.12()(64bit) is needed by (installed) iproute-tc-5.8.0-1.fc33.x86_64
libxtables.so.12()(64bit) is needed by (installed) nftables-1:0.9.3-6.fc33.x86_64
libxtables.so.12()(64bit) is needed by (installed) iptables-nft-1.8.5-3.fc33.x86_64
"evra": "2:4.12.7-0.fc32.x86_64" | ||
"evra": "2:4.13.0-11.fc33.x86_64" | ||
}, | ||
"samba-libs": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new requirement of samba-client-libs
:
[core@cosa-devsh ~]$ rpm -e samba-libs
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
libdcerpc-server-core.so.0()(64bit) is needed by (installed) samba-client-libs-2:4.13.0-11.fc33.x86_64
libdcerpc-server-core.so.0(DCERPC_SERVER_CORE_0.0.1)(64bit) is needed by (installed) samba-client-libs-2:4.13.0-11.fc33.x86_64
"evra": "2:4.8.1-2.fc32.x86_64" | ||
"evra": "2:4.8.1-4.fc33.x86_64" | ||
}, | ||
"shared-mime-info": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwupd
:
[core@cosa-devsh ~]$ rpm -e shared-mime-info
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
shared-mime-info is needed by (installed) libxmlb-0.2.1-1.fc33.x86_64
shared-mime-info is needed by (installed) fwupd-1.4.6-1.fc33.x86_64
OK so a lot of this is fwupd which was previously discussed here coreos/fedora-coreos-tracker#449 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned, a lot of stuff from fwupd here which I think needs more investigation.
"evra": "32-3.noarch" | ||
"evra": "33-0.15.noarch" | ||
}, | ||
"fedora-release-identity-coreos": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's coming from fedora-release-common
requiring fedora-release-identity
which fedora-release-identity-coreos
provides. But yeah, seems harmless.
"evra": "32-6.noarch" | ||
"evra": "33-0.13.noarch" | ||
}, | ||
"fedora-repos-modular": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Related: we should sanity-check our disablement still works there.
"evra": "0.7.14-1.fc32.x86_64" | ||
"evra": "0.7.14-4.fc33.x86_64" | ||
}, | ||
"libsoup": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is unfortunate. We were avoiding pulling in both libcurl and libsoup by having OSTree compiled against the former.
}, | ||
"mpfr": { | ||
"evra": "4.0.2-5.fc32.x86_64" | ||
}, | ||
"ncurses": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, this has reset
which can be super useful for saving a broken terminal (and tput
/tset
which I think can be useful too though I've only used it a few times). Tempted to add that one back.
2918c70
to
2b11457
Compare
While we still have some deps that we want to investigate as part of this change (for example fwupd) we need to make progress here. We can track down remaining issues and dependencies for f33 while it bakes in The two biggest offenders on bringing in new packages were |
This is ready for final review now. |
issues with podman in F33 (yay) are causing CI failures see: containers/podman#5364 (comment) |
2b11457
to
36f99e0
Compare
manifest-lock.overrides.aarch64.yaml
Outdated
# Fast-track systemd with the networkd subpackage split | ||
# <insert link to bodhi update here when it is created> | ||
systemd: | ||
evra: 246.4-3.fc33.aarch64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be 246.6-3, right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
indeed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in most recent push
de26e6a
to
c372d8e
Compare
c372d8e
to
8a8edf7
Compare
c10a801
to
bff87c5
Compare
Force pushed a new update with newer podman. |
Re. the root reprovisioning test failures, reproduced it locally and it seems like |
SGTM: #665 |
bff87c5
to
80aea54
Compare
ok.. hopefully #667 is the only remaining piece before this starts passing CI and we can merge this. |
80aea54
to
4a7272f
Compare
b6beb54
to
d57a787
Compare
This also includes updating the `fedora-next` repo so we can pull from the development development location since we are still in development. We also add back in the modular repos, which were split out into a subpackage in Fedora 33. Fixes coreos/fedora-coreos-tracker#611
Bodhi says some of these are stable already but the nightly composes are failing so they aren't actually in the yum repos yet so let's put them in as overrides for now. Also update the generated lockfile with the output of a local run of `cosa fetch --update-lockfile` to pre-seed file with F33 content.
d57a787
to
589aeba
Compare
🤞 that CI passes this time! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on this!
Yay CI passed! I'm going to drop the last commit from this PR and put them in a new PR against |
589aeba
to
de7e7ad
Compare
These commits perform the rebase to Fedora 33.
Part of the work for coreos/fedora-coreos-tracker#611