Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[next-devel] rebase to Fedora 33 #640

Merged
merged 3 commits into from
Oct 6, 2020

Conversation

dustymabe
Copy link
Member

These commits perform the rebase to Fedora 33.

Part of the work for coreos/fedora-coreos-tracker#611

@dustymabe dustymabe added the hold label Sep 24, 2020
@dustymabe
Copy link
Member Author

Right now zincati isn't in the f33 repos so you'll need to download the latest rpm for f33 into the overrides/rpm/ folder before doing a loca cosa build with:

$ cosa fetch --with-cosa-overrides && cosa build

@dustymabe
Copy link
Member Author

dustymabe commented Oct 1, 2020

current important changes when building locally right after building f32:

Removed:                                                                                                              
  dbxtool-8-12.fc32.x86_64                                                                                            
  libdb-utils-5.3.28-40.fc32.x86_64                                                                                                                                                                                                          
  mozjs60-60.9.0-5.fc32.x86_64                             
  ncurses-6.1-15.20191109.fc32.x86_64                                                                                                                                                                                                        
Added:                                                                                                                
  ModemManager-glib-1.14.2-1.fc33.x86_64                                                                                                                                                                                                     
  dmidecode-1:3.2-8.fc33.x86_64                                                                                                                                                                                                              
  fedora-release-identity-coreos-33-0.15.noarch            
  fedora-repos-modular-33-0.13.noarch                                                                                                                                                                                                        
  flashrom-1.2-3.fc33.x86_64                                                                                          
  fwupd-1.4.6-1.fc33.x86_64                                
  glib-networking-2.66.0-1.fc33.x86_64                                                                                
  gsettings-desktop-schemas-3.38.0-1.fc33.x86_64                                                                                                                                                                                             
  hwdata-0.339-1.fc33.noarch                                                                                          
  libeconf-0.3.8-4.fc33.x86_64                                                                                        
  libftdi-1.4-3.fc33.x86_64                                                                                           
  libgcab1-1.4-3.fc33.x86_64                                                                                          
  libgudev-234-1.fc33.x86_64                                                                                                                                                                                                                 
  libgusb-0.3.5-1.fc33.x86_64                                                                                                                                                                                                                
  libibverbs-31.0-1.fc33.x86_64                                                                                                                                                                                                              
  libjcat-0.1.3-3.fc33.x86_64                                                                                                                                                                                                                
  libmbim-1.24.2-1.fc33.x86_64                                                                                                                                                                                                               
  libmodman-2.0.1-23.fc33.x86_64                                                                                      
  libproxy-0.4.15-24.fc33.x86_64                                                                                      
  libqmi-1.26.4-1.fc33.x86_64                                                                                                                                                                                                                
  libsmbios-2.4.2-10.fc33.x86_64                                                                                                                                                                                                             
  libsoup-2.72.0-3.fc33.x86_64                                                                                                                                                                                                               
  libxmlb-0.2.1-1.fc33.x86_64                                                                                         
  mozjs78-78.3.0-1.fc33.x86_64                                                                                        
  pciutils-3.6.4-2.fc33.x86_64                                                                                        
  pciutils-libs-3.6.4-2.fc33.x86_64                                                                                                                                                                                                          
  rdma-core-31.0-1.fc33.x86_64                                                                                                                                                                                                               
  samba-libs-2:4.13.0-11.fc33.x86_64                                                                                  
  shared-mime-info-2.0-3.fc33.x86_64

We can discuss each one of these in the file diff as well.

@dustymabe
Copy link
Member Author

Right now zincati isn't in the f33 repos so you'll need to download the latest rpm for f33 into the overrides/rpm/ folder before doing a loca cosa build with:

$ cosa fetch --with-cosa-overrides && cosa build

This is fixed now with https://bodhi.fedoraproject.org/updates/FEDORA-2020-2fbcdf6262

@@ -1,1145 +1,1220 @@
{
"packages": {
"ModemManager-glib": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed by fwupd

$ rpm -e ModemManager-glib
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
        libmm-glib.so.0()(64bit) is needed by (installed) fwupd-1.4.6-1.fc33.x86_64

},
"dbus-libs": {
"evra": "1:1.12.20-1.fc32.x86_64"
},
"dbxtool": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in Fedora 32 this was needed by shim:

[core@localhost ~]$ rpm -e dbxtool
error: Failed dependencies:
	dbxtool >= 0.6-3 is needed by (installed) shim-x64-15-8.x86_64

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in Fedora 33 dbxtool is provided by the fwupd rpm and not the dbxtool rpm.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear to me that shim should hard require fwupd.

Now...shipping an OS without a way to update the DBX is probably not a good idea, but fwupd is now doing a lot.

},
"diffutils": {
"evra": "3.7-4.fc32.x86_64"
},
"dmidecode": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed by flashrom which is needed by fwupd:


```$ rpm -e dmidecode        
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
        dmidecode is needed by (installed) flashrom-1.2-3.fc33.x86_64

"evra": "32-3.noarch"
"evra": "33-0.15.noarch"
},
"fedora-release-identity-coreos": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new package not sure how it automagically gets installed but it looks like we do want it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's coming from fedora-release-common requiring fedora-release-identity which fedora-release-identity-coreos provides. But yeah, seems harmless.

"evra": "32-6.noarch"
"evra": "33-0.13.noarch"
},
"fedora-repos-modular": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new package. fedora-repos-modular was broken into a subpackage

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: we should sanity-check our disablement still works there.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah. it does I think. Part of the reason I knew I needed to add them back is because the "disablement" code was failing :)

"pciutils": {
"evra": "3.6.4-2.fc33.x86_64"
},
"pciutils-libs": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed by pciutils (leads to iptables) and flashrom (leads to fwupd):

[core@cosa-devsh ~]$ rpm -e pciutils-libs
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
        libpci.so.3()(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
        libpci.so.3()(64bit) is needed by (installed) flashrom-1.2-3.fc33.x86_64
        libpci.so.3(LIBPCI_3.0)(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
        libpci.so.3(LIBPCI_3.0)(64bit) is needed by (installed) flashrom-1.2-3.fc33.x86_64
        libpci.so.3(LIBPCI_3.1)(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
        libpci.so.3(LIBPCI_3.3)(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
        libpci.so.3(LIBPCI_3.3)(64bit) is needed by (installed) flashrom-1.2-3.fc33.x86_64
        libpci.so.3(LIBPCI_3.5)(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
        libpci.so.3(LIBPCI_3.5)(64bit) is needed by (installed) flashrom-1.2-3.fc33.x86_64
        libpci.so.3(LIBPCI_3.6)(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
        libpci.so.3(LIBPCI_3.7)(64bit) is needed by (installed) pciutils-3.6.4-2.fc33.x86_64
        pciutils-libs = 3.6.4-2.fc33 is needed by (installed) pciutils-3.6.4-2.fc33.x86_64

"evra": "2:2.1.0-2.fc32.x86_64"
"evra": "2:2.1.0-0.179.dev.git43f2771.fc33.x86_64"
},
"podman-plugins": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be dropped soon when new build of podman hits stable that only recommends and doesn't require podman-plugins.

"evra": "4.0.2-5.fc32.x86_64"
"evra": "4.0.2-6.fc33.x86_64"
},
"rdma-core": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ultimately needed by iptables:

[core@cosa-devsh ~]$ rpm -e rdma-core
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
        rdma-core(x86-64) = 31.0-1.fc33 is needed by (installed) libibverbs-31.0-1.fc33.x86_64
[core@cosa-devsh ~]$ rpm -e libibverbs
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
        libibverbs.so.1()(64bit) is needed by (installed) libpcap-14:1.9.1-5.fc33.x86_64
        libibverbs.so.1(IBVERBS_1.0)(64bit) is needed by (installed) libpcap-14:1.9.1-5.fc33.x86_64
        libibverbs.so.1(IBVERBS_1.1)(64bit) is needed by (installed) libpcap-14:1.9.1-5.fc33.x86_64
[core@cosa-devsh ~]$ rpm -e libpcap   
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
        libpcap.so.1()(64bit) is needed by (installed) iptables-libs-1.8.5-3.fc33.x86_64
        libpcap.so.1()(64bit) is needed by (installed) nmap-ncat-2:7.80-5.fc33.x86_64
[core@cosa-devsh ~]$ rpm -e iptables-libs
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
        iptables-libs(x86-64) = 1.8.5-3.fc33 is needed by (installed) iptables-1.8.5-3.fc33.x86_64
        iptables-libs(x86-64) = 1.8.5-3.fc33 is needed by (installed) iptables-nft-1.8.5-3.fc33.x86_64
        libip4tc.so.2()(64bit) is needed by (installed) systemd-246.6-3.fc33.x86_64
        libip4tc.so.2()(64bit) is needed by (installed) iptables-1.8.5-3.fc33.x86_64
        libip6tc.so.2()(64bit) is needed by (installed) iptables-1.8.5-3.fc33.x86_64
        libxtables.so.12()(64bit) is needed by (installed) iptables-1.8.5-3.fc33.x86_64
        libxtables.so.12()(64bit) is needed by (installed) iproute-tc-5.8.0-1.fc33.x86_64
        libxtables.so.12()(64bit) is needed by (installed) nftables-1:0.9.3-6.fc33.x86_64
        libxtables.so.12()(64bit) is needed by (installed) iptables-nft-1.8.5-3.fc33.x86_64

"evra": "2:4.12.7-0.fc32.x86_64"
"evra": "2:4.13.0-11.fc33.x86_64"
},
"samba-libs": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new requirement of samba-client-libs:

[core@cosa-devsh ~]$ rpm -e samba-libs
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
        libdcerpc-server-core.so.0()(64bit) is needed by (installed) samba-client-libs-2:4.13.0-11.fc33.x86_64
        libdcerpc-server-core.so.0(DCERPC_SERVER_CORE_0.0.1)(64bit) is needed by (installed) samba-client-libs-2:4.13.0-11.fc33.x86_64

"evra": "2:4.8.1-2.fc32.x86_64"
"evra": "2:4.8.1-4.fc33.x86_64"
},
"shared-mime-info": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwupd:

[core@cosa-devsh ~]$ rpm -e shared-mime-info
warning: Found bdb Packages database while attempting sqlite backend: using bdb backend.
error: Failed dependencies:
        shared-mime-info is needed by (installed) libxmlb-0.2.1-1.fc33.x86_64
        shared-mime-info is needed by (installed) fwupd-1.4.6-1.fc33.x86_64

@cgwalters
Copy link
Member

OK so a lot of this is fwupd which was previously discussed here coreos/fedora-coreos-tracker#449

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned, a lot of stuff from fwupd here which I think needs more investigation.

"evra": "32-3.noarch"
"evra": "33-0.15.noarch"
},
"fedora-release-identity-coreos": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's coming from fedora-release-common requiring fedora-release-identity which fedora-release-identity-coreos provides. But yeah, seems harmless.

"evra": "32-6.noarch"
"evra": "33-0.13.noarch"
},
"fedora-repos-modular": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: we should sanity-check our disablement still works there.

"evra": "0.7.14-1.fc32.x86_64"
"evra": "0.7.14-4.fc33.x86_64"
},
"libsoup": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is unfortunate. We were avoiding pulling in both libcurl and libsoup by having OSTree compiled against the former.

},
"mpfr": {
"evra": "4.0.2-5.fc32.x86_64"
},
"ncurses": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this has reset which can be super useful for saving a broken terminal (and tput/tset which I think can be useful too though I've only used it a few times). Tempted to add that one back.

@dustymabe
Copy link
Member Author

While we still have some deps that we want to investigate as part of this change (for example fwupd) we need to make progress here. We can track down remaining issues and dependencies for f33 while it bakes in next.

The two biggest offenders on bringing in new packages were fwupd (already covered by previously linked issue) and the iptables depchain because libpcap added support for rdma.

@dustymabe
Copy link
Member Author

This is ready for final review now.

@dustymabe dustymabe removed the hold label Oct 2, 2020
@dustymabe dustymabe changed the title WIP: [next-devel] rebase to Fedora 33 [next-devel] rebase to Fedora 33 Oct 2, 2020
@dustymabe
Copy link
Member Author

issues with podman in F33 (yay) are causing CI failures see: containers/podman#5364 (comment)

# Fast-track systemd with the networkd subpackage split
# <insert link to bodhi update here when it is created>
systemd:
evra: 246.4-3.fc33.aarch64
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be 246.6-3, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in most recent push

@dustymabe
Copy link
Member Author

Force pushed a new update with newer podman.

@jlebon
Copy link
Member

jlebon commented Oct 5, 2020

Re. the root reprovisioning test failures, reproduced it locally and it seems like ignition-ostree-dracut-rootfs is failing with ENOSPC. Even bumping it to 8G fails which tells me something else is going on there. We may need to bump the memory requirement across the board as #658 does, but for now can you just add another exclude while I investigate this?

@dustymabe
Copy link
Member Author

Re. the root reprovisioning test failures, reproduced it locally and it seems like ignition-ostree-dracut-rootfs is failing with ENOSPC. Even bumping it to 8G fails which tells me something else is going on there. We may need to bump the memory requirement across the board as #658 does, but for now can you just add another exclude while I investigate this?

SGTM: #665

@dustymabe
Copy link
Member Author

ok.. hopefully #667 is the only remaining piece before this starts passing CI and we can merge this.

@jlebon jlebon force-pushed the dusty-next-f33 branch 4 times, most recently from b6beb54 to d57a787 Compare October 6, 2020 15:37
This also includes updating the `fedora-next` repo so we can pull from
the development development location since we are still in development.
We also add back in the modular repos, which were split out into a
subpackage in Fedora 33.

Fixes coreos/fedora-coreos-tracker#611
Bodhi says some of these are stable already but the nightly composes
are failing so they aren't actually in the yum repos yet so let's
put them in as overrides for now.

Also update the generated lockfile with the output of a local run
of `cosa fetch --update-lockfile` to pre-seed file with F33 content.
@dustymabe
Copy link
Member Author

🤞 that CI passes this time!

Copy link
Member

@jlebon jlebon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on this!

@dustymabe
Copy link
Member Author

Yay CI passed! I'm going to drop the last commit from this PR and put them in a new PR against testing-devel (#670) since those files will get synced over by config bot. Since CI already passed I'm going to merge after dropping that last commit.

@dustymabe dustymabe merged commit 2addf27 into coreos:next-devel Oct 6, 2020
@dustymabe dustymabe deleted the dusty-next-f33 branch October 6, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants