Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

F33: ext.config.root-reprovision* tests failing #644

Closed
dustymabe opened this issue Oct 5, 2020 · 2 comments · Fixed by coreos/fedora-coreos-config#685
Closed

F33: ext.config.root-reprovision* tests failing #644

dustymabe opened this issue Oct 5, 2020 · 2 comments · Fixed by coreos/fedora-coreos-config#685
Assignees
@jlebon
Labels
jira for syncing to jira

Comments

@dustymabe
Copy link
Member

These tests are failing in the Fedora 33 rebase (coreos/fedora-coreos-config#640). We'll disable the tests for now to unblock.

@jlebon has done some preliminary investigation over in: coreos/fedora-coreos-config#640 (comment)
@jlebon jlebon self-assigned this Oct 5, 2020
@jlebon jlebon added the jira for syncing to jira label Oct 5, 2020
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Oct 5, 2020
@dustymabe
tests: add ext.config.root-reprovision to denylist for f33
f57382c 
The ext.config.root-reprovision* tests are failing on Fedora 33
for now. Exclude running the test on `next` and `next-devel`.

coreos/fedora-coreos-tracker#644
dustymabe added a commit to dustymabe/fedora-coreos-config that referenced this issue Oct 5, 2020
@dustymabe
tests: add ext.config.root-reprovision to denylist for f33
7997f53 
The ext.config.root-reprovision* tests are failing on Fedora 33
for now. Exclude running the test on `next` and `next-devel`.

coreos/fedora-coreos-tracker#644
@dustymabe dustymabe mentioned this issue Oct 5, 2020
Merged
dustymabe added a commit to coreos/fedora-coreos-config that referenced this issue Oct 5, 2020
@dustymabe
tests: add ext.config.root-reprovision to denylist for f33
de3ec99 
The ext.config.root-reprovision* tests are failing on Fedora 33
for now. Exclude running the test on `next` and `next-devel`.

coreos/fedora-coreos-tracker#644
jlebon added a commit to jlebon/fedora-coreos-config that referenced this issue Oct 14, 2020
@jlebon
ignition-ostree-rootfs: copy rootfs into separate tmpfs
f460706 
In f33 systemd, /run is now mounted with a smaller size cap instead of
the default 50%:

systemd/systemd#15424

This was causing the rootfs reprovisioning code to run out of space.

Let's use this as an opportunity to be more explicit about the memory
semantics we want. Notably, we don't care about starving the host here;
either we have enough memory to reprovision the rootfs, or we should
fail. So let's just mount our own tmpfs with `size=100%`.

This in turn means that machines need even *less* RAM for rootfs
reprovisioning to work. A local test shows 2.5G seems to be enough.
Though let's keep recommending 4G in the docs to be safe.

A minor thing this also fixes is that we now clean up a leftover
directory and file from `/run` before we switchroot.

Closes: coreos/fedora-coreos-tracker#644
jlebon added a commit to jlebon/fedora-coreos-config that referenced this issue Oct 14, 2020
@jlebon
ignition-ostree-rootfs: use our own tmpfs with size=100%
0690810 
In f33 systemd, /run is now mounted with a smaller size cap instead of
the default 50%:

systemd/systemd#15424

This was causing the rootfs reprovisioning code to run out of space.

Let's use this as an opportunity to be more explicit about the memory
semantics we want. Notably, we don't care about starving the host here;
either we have enough memory to reprovision the rootfs, or we should
fail. So let's just mount our own tmpfs with `size=100%`.

This in turn means that machines need even *less* RAM for rootfs
reprovisioning to work. A local test shows 2.5G seems to be enough.
Though let's keep recommending 4G in the docs to be safe.

A minor thing this also fixes is that we now clean up a leftover
directory and file from `/run` before we switchroot.

Closes: coreos/fedora-coreos-tracker#644
@jlebon jlebon mentioned this issue Oct 14, 2020
Merged
@jlebon
Copy link
Member

jlebon commented Oct 14, 2020

Fix for this in coreos/fedora-coreos-config#685.

jlebon added a commit to jlebon/fedora-coreos-config that referenced this issue Oct 14, 2020
@jlebon
ignition-ostree-rootfs: use our own tmpfs with size=80%
1c9a493 
In f33 systemd, /run is now mounted with a smaller size cap instead of
the default 50%:

systemd/systemd#15424

This was causing the rootfs reprovisioning code to run out of space.

Let's use this as an opportunity to be more explicit about the memory
semantics we want. Notably, we don't care about starving the host here;
either we have enough memory to reprovision the rootfs, or we should
fail. So let's just mount our own tmpfs with `size=80%`.

This in turn means that machines need even *less* RAM for rootfs
reprovisioning to work. A local test shows 2.5G seems to be enough.
Though let's keep recommending 4G in the docs to be safe.

A minor thing this also fixes is that we now clean up a leftover
directory and file from `/run` before we switchroot.

Closes: coreos/fedora-coreos-tracker#644
jlebon added a commit to coreos/fedora-coreos-config that referenced this issue Oct 14, 2020
@jlebon
ignition-ostree-rootfs: use our own tmpfs with size=80%
627f2e1 
In f33 systemd, /run is now mounted with a smaller size cap instead of
the default 50%:

systemd/systemd#15424

This was causing the rootfs reprovisioning code to run out of space.

Let's use this as an opportunity to be more explicit about the memory
semantics we want. Notably, we don't care about starving the host here;
either we have enough memory to reprovision the rootfs, or we should
fail. So let's just mount our own tmpfs with `size=80%`.

This in turn means that machines need even *less* RAM for rootfs
reprovisioning to work. A local test shows 2.5G seems to be enough.
Though let's keep recommending 4G in the docs to be safe.

A minor thing this also fixes is that we now clean up a leftover
directory and file from `/run` before we switchroot.

Closes: coreos/fedora-coreos-tracker#644
@dustymabe dustymabe added the status/pending-next-release Fixed upstream. Waiting on a next release. label Oct 15, 2020
@dustymabe dustymabe mentioned this issue Oct 21, 2020
Closed
@dustymabe
Copy link
Member Author

The fix for this went into next stream release 33.20201020.1.0. Please try out the new release and report issues.

@dustymabe dustymabe removed the status/pending-next-release Fixed upstream. Waiting on a next release. label Oct 21, 2020
kelvinfan001 pushed a commit to kelvinfan001/fedora-coreos-config that referenced this issue Dec 14, 2020
@dustymabe @kelvinfan001
tests: add ext.config.root-reprovision to denylist for f33
746f219 
The ext.config.root-reprovision* tests are failing on Fedora 33
for now. Exclude running the test on `next` and `next-devel`.

coreos/fedora-coreos-tracker#644
kelvinfan001 pushed a commit to kelvinfan001/fedora-coreos-config that referenced this issue Dec 14, 2020
@jlebon @kelvinfan001
ignition-ostree-rootfs: use our own tmpfs with size=80%
7cbcfa1 
In f33 systemd, /run is now mounted with a smaller size cap instead of
the default 50%:

systemd/systemd#15424

This was causing the rootfs reprovisioning code to run out of space.

Let's use this as an opportunity to be more explicit about the memory
semantics we want. Notably, we don't care about starving the host here;
either we have enough memory to reprovision the rootfs, or we should
fail. So let's just mount our own tmpfs with `size=80%`.

This in turn means that machines need even *less* RAM for rootfs
reprovisioning to work. A local test shows 2.5G seems to be enough.
Though let's keep recommending 4G in the docs to be safe.

A minor thing this also fixes is that we now clean up a leftover
directory and file from `/run` before we switchroot.

Closes: coreos/fedora-coreos-tracker#644
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jlebon jlebon

Labels
jira for syncing to jira
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ignition-ostree-rootfs: use our own tmpfs with size=80% jlebon/fedora-coreos-config
2 participants
@dustymabe @jlebon