Make sure resources are all tagged

[Quentin-M]

Tracking the issue mentioned in #218 (comment).

The fix should be in the next release.

[Quentin-M]

Would there be a way to add an automated test for that one?

[robszumski]

Automated tests would be great. Manually booting 1.6.4 release shows that these items are tagged with custom tags:

• security groups
• VPC
• Subnets

Not tagged with custom tags:

• EC2 vms
• ELBs
• ASGs

Not tagged at all:

• EBS volumes
• Internet Gateways

[Quentin-M]

Assigning to @estroz avec discussed offline! Thanks!

[estroz]

Tags by Resource Types as of 1.6.4:

*: Only some were tagged, not all
**: Only etcd node volumes are tagged

Resource Type	ClusterID	Extra tags
Instance	x	x*
ELB	x	x
Security Group	x	x
Route53 HostedZone	x	x
Route Table	x	x
Subnet	x	x
VPC	x	x
Network ACL (default)
Internet Gateway	x	x
Customer Gateway
Network Interface
Volume	x**	x**
S3 Bucket	x	x
Autoscaling Group	x

Note:

• ASG-controlled instances do not get extra tags
• ASG-controlled instance volumes cannot be tagged

[rithujohn191]

Needs more investigation for desired user experience.

[robszumski]

In the planning meeting we discussed:

• upstream Terraform doesn't support tagging for all resource types
• we could ship a binary that uses the raw APIs to accomplish this

I have reached out to our AWS contacts to see if they can lend any resources to improving the terraform support.

Shipping a separate binary or requiring users to interact with the raw providers API does not meet our UX requirements.

@estroz what was the limitation around tagging the auto-scaled instances?

[estroz]

All resource types that support tagging in AWS can be tagged by Terraform if explicitly created. However, default resources, ex. network interfaces created when creating an EC2 instance, or a resource created when creating a parent, cannot be tagged in certain cases. Regarding volumes of auto-scaled instances, `root_block_device` volumes specified by launch configurations cannot be tagged by Terraform, according to hashicorp/terraform#14558.

…

On Wed, Jul 12, 2017 at 7:24 AM, Rob Szumski ***@***.***> wrote: In the planning meeting we discussed: - upstream Terraform doesn't support tagging for all resource types - we could ship a binary that uses the raw APIs to accomplish this I have reached out to our AWS contacts to see if they can lend any resources to improving the terraform support. Shipping a separate binary or requiring users to interact with the raw providers API does not meet our UX requirements. @estroz <https://github.com/estroz> what was the limitation around tagging the auto-scaled instances? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1115 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMYjO1V8tFeEzzmsk7gtNn_zofSoQbAyks5sNNcmgaJpZM4N9vrx> .

[sym3tri]

This is complete. Just need to document the caveats for which i created a separate issue.

[ggreer]

Autoscaling groups still aren't getting tagged correctly. (Merged in #1314 and reverted in #1341)