This repository has been archived by the owner on Feb 5, 2020. It is now read-only.
Apply 'extra tags' to autoscaling groups #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
estroz
force-pushed
the
autoscaling-group-tags
branch
from
64cce88 to
1b16a5a
Compare
kans
reviewed
Jul 7, 2017
installer/frontend/cluster-config.js
Outdated
| const extraAutoScalingTags = {}; | ||
| _.each(cc[AWS_TAGS], ({key, value}) => { | ||
| if(key && value) { | ||
| extraAutoScalingTags.key = key; |
There was a problem hiding this comment.
It would also be OK to dump these three lines into the loop above.
edit:
It looks like extraAutoScalingTags should be an array and you should push objects onto it like so:
const extraAutoScalingTags = [];
...
extraAutoScalingTags.push({key, value, propagate_at_launch: true});There was a problem hiding this comment.
Fixing now.
I kept the autoscaling tags in a separate loop to keep the code clean.
estroz
force-pushed
the
autoscaling-group-tags
branch
3 times, most recently
from
39db2d3 to
5db4011
Compare
kans
reviewed
Jul 7, 2017
| @@ -54,6 +54,13 @@ | |||
| "value": "testing" | |||
| } | |||
| ], | |||
| "awsASGTags": [ | |||
There was a problem hiding this comment.
You should remove "awsASGTags" from both progress files (which will also get rid of the console.errors) - you'd only want these here if we were storing the tags in memory at this location, but we only really want to output a new tfvar.
kans
reviewed
Jul 7, 2017
installer/frontend/cluster-config.js
Outdated
| @@ -20,6 +20,7 @@ export const AWS_SECRET_ACCESS_KEY = 'awsSecretAccessKey'; | |||
| export const AWS_SESSION_TOKEN = 'awsSessionToken'; | |||
| export const AWS_SSH = 'aws_ssh'; | |||
| export const AWS_TAGS = 'awsTags'; | |||
| export const AWS_ASG_TAGS = 'awsASGTags'; | |||
There was a problem hiding this comment.
I don't think this is being used.
estroz
force-pushed
the
autoscaling-group-tags
branch
from
5db4011 to
cb4f436
Compare
kans
approved these changes
Jul 7, 2017
estroz
changed the title
kans
added a commit
that referenced
this pull request
Jul 10, 2017
Revert "Merge pull request #1314 from estroz/autoscaling-group-tags"
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
installer/frontend/: 'tectonic_autoscaling_group_extra_tags' will be populated by data from user-provided tags.
User-defined 'extra' tags are not being applied to autoscaling groups because tag data doesn't populate
tectonic_autoscaling_group_extra_tags.Applies to #1115