Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[easy] No longer mark engineering liberal studies data as allow double counting #575

Merged
merged 1 commit into from
Nov 17, 2021

Conversation

SamChou19815
Copy link
Contributor

Summary

To be merged after #554 is run on prod data.

Test Plan

👀

@SamChou19815 SamChou19815 requested a review from a team as a code owner November 6, 2021 14:35
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 1.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2021

Visit the preview URL for this PR (updated for commit b744915):

https://cornelldti-courseplan-dev--pr575-unmark-dyf35nh3.web.app

(expires Tue, 16 Nov 2021 19:50:23 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@hahnbeelee
Copy link
Contributor

technically can't this be merged to master and then later when we push to prod we should run the script on prod?

@SamChou19815
Copy link
Contributor Author

technically can't this be merged to master and then later when we push to prod we should run the script on prod?

yes that's right

Copy link
Contributor

@hahnbeelee hahnbeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. i ran the script on prod! I'll have to remember to run it again when we push to prod though.

@SamChou19815 SamChou19815 merged commit 091c667 into master Nov 17, 2021
@SamChou19815 SamChou19815 deleted the unmark branch November 17, 2021 03:29
SamChou19815 added a commit that referenced this pull request Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants