Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release containing only #575 #596

Merged
merged 2 commits into from
Nov 18, 2021
Merged

Release containing only #575 #596

merged 2 commits into from
Nov 18, 2021

Conversation

SamChou19815
Copy link
Contributor

@SamChou19815 SamChou19815 commented Nov 17, 2021

Summary

A small release that only contains #575 that changes the engineering liberal studies requirement. This PR's merge is delayed since we need to run migration scripts first. Now that the migration script is finished. It's time to release.

Edit: also contains the PR to delete migration scripts, which shouldn't impact end users.

Test Plan

👀

@SamChou19815 SamChou19815 requested a review from a team as a code owner November 17, 2021 03:34
@dti-github-bot
Copy link
Member

[diff-counting] Significant lines: 1.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 17, 2021

Visit the preview URL for this PR (updated for commit a418c6d):

https://cornelldti-courseplan-dev--pr596-master-4ibhfjp3.web.app

(expires Wed, 24 Nov 2021 04:15:49 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Finally all migration scripts are run!
Copy link
Contributor

@hahnbeelee hahnbeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Compared my engineering requirements between the deployment link and master. Seemed in sync.

Copy link
Collaborator

@benjamin-shen benjamin-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

Copy link
Member

@willespencer willespencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My liberal studies data works for each part of the requirement, courses cannot be double-counted with other requirements, and not fulfilling 1 part of the computed req leaves it unfulfilled.

@SamChou19815 SamChou19815 merged commit 1094222 into beta-release Nov 18, 2021
@benjamin-shen benjamin-shen added the release Release to production label Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release to production
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants