-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release containing only #575 #596
Conversation
[diff-counting] Significant lines: 1. |
Visit the preview URL for this PR (updated for commit a418c6d): https://cornelldti-courseplan-dev--pr596-master-4ibhfjp3.web.app (expires Wed, 24 Nov 2021 04:15:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Finally all migration scripts are run!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compared my engineering requirements between the deployment link and master. Seemed in sync.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! My liberal studies data works for each part of the requirement, courses cannot be double-counted with other requirements, and not fulfilling 1 part of the computed req leaves it unfulfilled.
Summary
A small release that only contains #575 that changes the engineering liberal studies requirement. This PR's merge is delayed since we need to run migration scripts first. Now that the migration script is finished. It's time to release.
Edit: also contains the PR to delete migration scripts, which shouldn't impact end users.
Test Plan
👀