-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Applied Economics Minor #773
Conversation
[diff-counting] Significant lines: 66. |
@jerrry1123 @rohanmaheshwari430 might want to review this for dev portfolio. |
Visit the preview URL for this PR (updated for commit a27dd8c): https://cornelldti-courseplan-dev--pr773-aem-minor-99urvnts.web.app (expires Fri, 10 Mar 2023 18:06:42 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
make sure the minor is added to the req list! |
@@ -375,6 +376,12 @@ const json: RequirementsJson = { | |||
}, | |||
}, | |||
minor: { | |||
AEM: { | |||
name: 'Applied Economics and Management', | |||
schools: ['AG', 'BU'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't every college except dyson be allowed to do the minor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zachary0kent am I wrong about how this works
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know that some colleges like engineering ahve their own version of their AEM minor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@noschiff I believe this refers to which college offers the minor, not those eligible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where do we store which colleges are eligible? @zachary0kent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe we do? I'm not aware of such restrictions typically existing anyways.
Remember to run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we name this "Applied Economics" instead of AEM? The minor is officially applied economics, whereas AEM usually refers to the Dyson major (M for & Management).
@mirandayu131 can you add more information to the PR overview? It'd be good to have a link to the source of requirements for the reviewer to reference, as well as a test plan. The test plan for adding a major is usually pretty brief though :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I'll leave the approval + testing to one of the devs for their portfolio :)
I did the testing plan and all the requirements look right, I just think that it might be better to rename the minor to non-engineering or something like that to differentiate this minor from the engineering business minor. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did the testing plan and all the requirements look right, I just think that it might be better to rename the minor to non-engineering or something like that to differentiate this minor from the engineering business minor.
@@ -375,6 +376,12 @@ const json: RequirementsJson = { | |||
}, | |||
}, | |||
minor: { | |||
AEM: { | |||
name: 'Applied Economics and Management', | |||
schools: ['AG', 'BU'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i know that some colleges like engineering ahve their own version of their AEM minor
Summary
Added the Business minor for Applied Economics in the SC Johnson College of Business.
Information on the requirements is sourced from the following:
[https://business.cornell.edu/programs/undergraduate/minors/applied-economics/]
Test Plan
Test AE minor!