Spring 2023 Release #833
Merged
Spring 2023 Release #833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* implemented cleansing function * Explains what NBS is * Format
|
|
|
[diff-counting] Significant lines: 2090. This diff might be too big! Developer leads are invited to review the code. |
noschiff
requested review from
zachary-kent
and removed request for
michelleli01 and
epicdragon44
|
Visit the preview URL for this PR (updated for commit 451fc55): https://cornelldti-courseplan-dev--pr833-staging-release-yttll8n8.web.app (expires Tue, 26 Sep 2023 02:12:38 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d4e0437c4559ed895272bbd63991394f1e0e933 |
Prepare Spring 2023 Release
* Bypass CI Check for Release Branch * remove logging
rohanmaheshwari430
previously approved these changes
May 11, 2023
README.md
Outdated
| - **Rohan Maheshwari** - Developer | ||
| - **Elizabeth Tang** - Developer | ||
| - **Pablo Raigoza** - Developer | ||
| - **Noorejehan Umarn** - Designer |
There was a problem hiding this comment.
Noor's last name is spelled wrong!
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 2.9.13 to 2.9.16. - [Release notes](https://github.com/vitejs/vite/releases) - [Changelog](https://github.com/vitejs/vite/blob/v2.9.16/packages/vite/CHANGELOG.md) - [Commits](https://github.com/vitejs/vite/commits/v2.9.16/packages/vite) --- updated-dependencies: - dependency-name: vite dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.4) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
zachary-kent
previously approved these changes
Aug 26, 2023
There was a problem hiding this comment.
I tested all of the changes thoroughly to ensure everything works as expected. Specifically, I verified the following:
- All new minors work as intended
- "Other Yes List" courses do indeed fulfill the liberal studies requirement
- Abbreviations for colleges, majors, and minors are human readable on the progress tracker toolcard.
- Retrieving data from the central course data collection works correctly, even using the prod Firestore.
zachary-kent
dismissed stale reviews from rohanmaheshwari430 and themself
via
451fc55
zachary-kent
requested review from
rohanmaheshwari430
and removed request for
epicdragon44 and
michelleli01
zachary-kent
approved these changes
Aug 27, 2023
andxu282
approved these changes
Aug 27, 2023
KaylinChan
approved these changes
Aug 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This release features substantial improvement to our requirements and course infrastructure and data.
Changes
Front & Back End
Requirements
More
Test Plan
Confirm everything works as expected on all pages of CoursePlan site, especially components that use course data, with no console errors.
Notes
Do not squash and merge. Wait until #832 is merged.