fix(cornerstone-dicom-sr): Freehand SR hydration support #1160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cornerstone-3d-docs canceled.
|
4 tasks
igoroctaviano
changed the title
sedghi
reviewed
Mar 20, 2024
| @@ -243,7 +268,7 @@ class PlanarFreehandROITool extends ContourSegmentationBaseTool { | |||
| */ | |||
| epsilon: 0.1, | |||
| }, | |||
| calculateStats: false, | |||
| calculateStats: true, | |||
There was a problem hiding this comment.
can we set it back to false, it is brutal to calculate stats on each frame
There was a problem hiding this comment.
The stats were not being calculated / displayed. Maybe the problem is the tool implementation or when the stats are calculated?
sedghi
reviewed
Mar 20, 2024
igoroctaviano
changed the title
igoroctaviano
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The Freehand ROI annotation SR hydration was not working for both SR and Cornerstone viewports
Changes & Results
Testing
PR
semantic-release format and guidelines.
Code
N/A
Public Documentation Updates
N/A
Tested Environment