-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cornerstone-dicom-sr): Freehand SR hydration support #1160
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
15e15df
Fix freehand sr annotation load
igoroctaviano eb51a04
Add perimeter and cached stats
igoroctaviano 0beaf01
Update import
igoroctaviano cd6a4c9
Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into fi…
igoroctaviano 1b408ab
Add perimeter
igoroctaviano ba80aa2
Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into fi…
igoroctaviano 835d614
Merge branch 'main' of github.com:cornerstonejs/cornerstone3D into fi…
igoroctaviano c2bbfc1
Update docs
igoroctaviano File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
packages/tools/src/utilities/contours/calculatePerimeter.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
/** | ||
* Calculates the perimeter of a polyline. | ||
* | ||
* @param polyline - The polyline represented as an array of points. | ||
* @param closed - Indicates whether the polyline is closed or not. | ||
* @returns The perimeter of the polyline. | ||
*/ | ||
function calculatePerimeter(polyline: number[][], closed: boolean): number { | ||
let perimeter = 0; | ||
|
||
for (let i = 0; i < polyline.length - 1; i++) { | ||
const point1 = polyline[i]; | ||
const point2 = polyline[i + 1]; | ||
perimeter += Math.sqrt( | ||
Math.pow(point2[0] - point1[0], 2) + Math.pow(point2[1] - point1[1], 2) | ||
); | ||
} | ||
|
||
if (closed) { | ||
const firstPoint = polyline[0]; | ||
const lastPoint = polyline[polyline.length - 1]; | ||
perimeter += Math.sqrt( | ||
Math.pow(lastPoint[0] - firstPoint[0], 2) + | ||
Math.pow(lastPoint[1] - firstPoint[1], 2) | ||
); | ||
} | ||
|
||
return perimeter; | ||
} | ||
|
||
export default calculatePerimeter; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we set it back to false, it is brutal to calculate stats on each frame
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The stats were not being calculated / displayed. Maybe the problem is the tool implementation or when the stats are calculated?