This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
[UX] Increase touch target for switches #455
Assignees
Labels
Comments
This was referenced Jun 14, 2020
|
I have fixed this in #466, it just needs to be reviewed and merged |
harambasicluka
added a commit
that referenced
this issue
Jun 25, 2020
* fixes #455 by referencing the entire SettingsSwitchRow instead of just the SettingsSwitchRowSwitch * Fixed Switched having no OnClickListener anymore and therefore not working. Switches AND Rows now have an OnClickListener to change the setting. * implemented requested changes from harambasicluka; (in onClickListener) checking if row is enabled before executing action * fixed formatting that caused quickBuild to fail * moved the isEnabled check to the row instead of switch Co-authored-by: harambasicluka <64483219+harambasicluka@users.noreply.github.com>
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Current Implementation
Currently if the user wants to change a setting that includes a
switchhe has to click on the switch (see red rectangel in the picture)Suggested Enhancement
From a usability/user experience point of view it would be better to "just tap somewhere where the text is" (green rectangle). This behaviour can be seen in the android settings or the Google Play Stores Notifications settings. So the user knows (and maybe also expects) this behaviour
Expected Benefits
Easier and more convenient way of "switching" some settings.
The text was updated successfully, but these errors were encountered: