Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Make entire SettingsRow toggle the setting (closes #455) #459

Closed
wants to merge 12 commits into from
Closed

Make entire SettingsRow toggle the setting (closes #455) #459

wants to merge 12 commits into from

Conversation

tomjschwanke
Copy link
Contributor

fixes #455

Checklist

  • Test your changes as thoroughly as possible before you commit them. Preferably, automate your test by unit/integration tests.
  • If this PR comes from a fork, please Allow edits from maintainers
  • Set a speaking title. Format: {task_name} (closes #{issue_number}). For example: Use logger (closes # 41)
  • Link your Pull Request to an issue (if applicable)
  • Create Work In Progress [WIP] pull requests only if you need clarification or an explicit review before you can continue your work item.
  • Make sure that your PR is not introducing unnecessary reformatting (e.g., introduced by on-save hooks in your IDE)
  • Make sure that your PR does not contain changes in strings.xml (see issue [HELP WANTED][README] Text / Translations  #332)
  • Make sure that your PR does not contain compiled sources (already set by the default .gitignore) and / or binary files

Description

#455 mentioned the settings being only toggleable by hitting the switch. This PR makes the entire SettingsRow toggle the switch, making it behave like stock Android settings.

@tomjschwanke tomjschwanke requested a review from a team June 14, 2020 20:14
@tomjschwanke
Copy link
Contributor Author

This would need to be remembered for all settings added in the future

@tomjschwanke
Copy link
Contributor Author

tomjschwanke commented Jun 14, 2020

Todo: maybe fix the animation, stock Android has a little animation, filling the box from where you tapped. In the current implementation, it lights up the entire box immediately

@tomjschwanke
Copy link
Contributor Author

tomjschwanke commented Jun 15, 2020

Edit: should've probably proposed this PR to dev instead of master.

Can't change it now, should I make a new one proposing this to dev?

@ironjan
Copy link
Contributor

ironjan commented Jun 15, 2020 via email

@tomjschwanke tomjschwanke changed the base branch from master to dev June 15, 2020 07:07
@tomjschwanke
Copy link
Contributor Author

tomjschwanke commented Jun 15, 2020

Now there are a lot of unrelated commits in this PR, should I make a new PR coming from my forks dev branch.

As for CircleCI failing, I'd need to run gradle quickBuild first, right?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UX] Increase touch target for switches
5 participants