This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 496
Make entire SettingsRow toggle the setting (closes #455) #459
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0.8.15 Hotfix
…tingsSwitchRowSwitch
This would need to be remembered for all settings added in the future |
Todo: maybe fix the animation, stock Android has a little animation, filling the box from where you tapped. In the current implementation, it lights up the entire box immediately |
|
@tomjschwanke you should be able to change the base branch as described on
https://github.blog/2016-08-15-change-the-base-branch-of-a-pull-request/
…On Mon, 15 Jun 2020, 08:56 Tom Schwanke, ***@***.***> wrote:
Edit: should've probably proposed this PR to dev instead of master.
Can't change it now, should I make a new one proposing this to dev?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#459 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAM6YFFCUJ66W2JZEPGUTNTRWXAZZANCNFSM4N5THD6A>
.
|
Now there are a lot of unrelated commits in this PR, should I make a new PR coming from my forks dev branch. As for CircleCI failing, I'd need to run |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #455
Checklist
Description
#455 mentioned the settings being only toggleable by hitting the switch. This PR makes the entire SettingsRow toggle the switch, making it behave like stock Android settings.