Skip to content
This repository has been archived by the owner on Jun 20, 2023. It is now read-only.

Sonar Cloud crashes on External PRs #539

Closed
tkowark opened this issue Jun 16, 2020 · 3 comments
Closed

Sonar Cloud crashes on External PRs #539

tkowark opened this issue Jun 16, 2020 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@tkowark
Copy link
Member

tkowark commented Jun 16, 2020

Describe the bug

When running Sonar Cloud for external PRs, the CircleCI build crashes as information about the branches is not properly handed over by (most likely) SonarCloud.

Expected behaviour

Sonar Cloud should be skipped for external PRs o SonarCloud should fail silently (as it does for, for example, cwa-server)

Steps to reproduce the issue

#515

Possible Fix

#373

@tkowark tkowark added the bug Something isn't working label Jun 16, 2020
@jakobmoellerdev jakobmoellerdev added the in progress The issue is currently being resolved label Jun 17, 2020
@jakobmoellerdev jakobmoellerdev self-assigned this Jun 17, 2020
@jakobmoellerdev jakobmoellerdev removed the in progress The issue is currently being resolved label Jun 17, 2020
@pr1metine
Copy link
Contributor

It looks like SonarCloud still crashes on community PRs, see #655 #692 .

@tkowark
Copy link
Member Author

tkowark commented Jun 21, 2020

It seems that your .circle/config.yml differs from the one in master and dev of the cwa-app-android repo. In particular, this line is missing, which prevents sonar-scanner from running on external PRs. Could you please fetch all upstream changes from the repo?

@pr1metine
Copy link
Contributor

Hmm, I see.

Someone else did that for me. Now I am unauthorized to do anything after I tried to commit changes, see #695 .

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants